From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id A68211F62B for ; Fri, 24 Feb 2023 19:42:50 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=shopify.com header.i=@shopify.com header.a=rsa-sha256 header.s=google header.b=TDkto3h6; dkim-atps=neutral Received: by mail-oi1-x22f.google.com with SMTP id bk32so115854oib.10 for ; Fri, 24 Feb 2023 11:42:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6eqMCLjXWsOB6umNi7661EH18XmHuqc88URGbp/egXM=; b=TDkto3h6PushvtB8/Ea/OJa/4GxrfVydhzKcS0Tw6+8rgQyRqINarRCuB98ZpElbr+ LY3/F8tlzax/KvGDHKsAOcfRzqmiaS7+hMoXjYs7YU3yWrNpB5HcdktIxlYq8TxXlNUF mcsTSfQRkY43mD5jFUTeeGqDhBHn98Yza5vRI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6eqMCLjXWsOB6umNi7661EH18XmHuqc88URGbp/egXM=; b=Pfu7B9PpdR2/ocQWL81MeRYqZqssTkS4HC5kZIREHYw6uZlGYZMRzWxkYV6gfBffyy cYzkKEOnciQZkdofhCg0EkJE9rEWAaRqrtu7x0hidMqDfSfsFaTILE1KL4Umw4k80XrQ 5W7DcUpQ9J5uyM9zcgHy38Rm3mUrrYrvYaO4TqR8EX4p+dPY5pWSF9qym9cNNz064pIK jb0b0IN8r5pbSGnoahpWWH/5zTGzcf9jVmZWRe/O92F4QoIHAc5fVjiuwLkDHqxTAKg8 XV2Zp6p+C3Ys+SGlYJdeapK7fpB5A/fU5vzKO0jaZb0wcobCN0i9JMnTkig9wUuXT2be 0QNQ== X-Gm-Message-State: AO0yUKUVsJUiFf8zC+FtZGLruJEgl537jpygza3rCHUA3hO+w21OjkCq FRIaZLzMYleeh9Q0p2hXhdMLQAYhxD2Ka6/6EzPTmn8fuRk/Qyst X-Google-Smtp-Source: AK7set/jKtf2nZReJwbzuitCeyAJMFvifN6ls1ClWxLY+UELOISMauVi9SJs4H7Y1bIiZEOmsqbizVS75m0LzfCoLBw= X-Received: by 2002:a05:6808:2c4:b0:384:a7b:b457 with SMTP id a4-20020a05680802c400b003840a7bb457mr355936oid.6.1677267769582; Fri, 24 Feb 2023 11:42:49 -0800 (PST) MIME-Version: 1.0 References: <20230224183544.51837-1-dale.hamel@shopify.com> <20230224190922.M629699@dcvr> In-Reply-To: <20230224190922.M629699@dcvr> From: Dale Hamel Date: Fri, 24 Feb 2023 14:42:38 -0500 Message-ID: Subject: Re: [PATCH] Fix queue stats for sockets with SO_REUSEPORT To: Eric Wong Cc: raindrops-public@yhbt.net Content-Type: text/plain; charset="UTF-8" List-Id: > I'm honestly shocked that these features get used; > I never convinced the org I worked for to use them :x So far we haven't actually found a production use case for SO_REUSEPORT with Unicorn. We thought we had some promising early results - but it turned out to be this instrumentation error in raindrops. At least by fixing this, efforts in the future will have the correct metrics to base tests off of. > Anything else? Could tag a release in a bit... No, that's it! My apologies for sending as two patches, I didn't notice the bug in my test until I had already submitted, naturally. Thanks very much for the quick review!