From: Hleb Valoshka <375gnu@gmail.com>
To: raindrops@librelist.org
Subject: Re: [PATCH 2/2] Return real stats instead of True
Date: Mon, 9 Sep 2013 22:37:12 +0300 [thread overview]
Message-ID: <CAAB-KckpMYtQo3yeXAu1Su=Up+_g8vyU23DNPYBojwdtFCEy5A@mail.gmail.com> (raw)
In-Reply-To: 20130909192020.GA18010@dcvr.yhbt.net
On 9/9/13, Eric Wong <normalperson@yhbt.net> wrote:
> This deserves an explanation (and ideally, a test case). I haven't
> looked at the code in a while and needed to think a bit about
> when the fix is relevant.
You better reject it. I've made it because of test failure:
Error: test_tcp_multi(TestLinuxIPv6)
NoMethodError: undefined method `queued' for true:TrueClass
test/test_linux_ipv6.rb:54:in `test_tcp_multi'
51: addrs = [ addr1, addr2 ]
52: stats = tcp_listener_stats(addrs)
53: assert_equal 2, stats.size
=> 54: assert_equal 0, stats[addr1].queued
55: assert_equal 0, stats[addr1].active
56: assert_equal 0, stats[addr2].queued
57: assert_equal 0, stats[addr2].active
With that changes test's passed. (I didn't noticed that time that you
process that Qtrues).
But the real reason may be something else: I've got IPv6 address using
Teredo and getnameinfo returns error with it. So it cause other
errors, I need to check it better.
next prev parent reply other threads:[~2013-09-09 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 19:03 [PATCH 1/2] Add setup and teardown for ipv6 tests Hleb Valoshka
2013-09-09 19:03 ` [PATCH 2/2] Return real stats instead of True Hleb Valoshka
2013-09-09 19:20 ` Eric Wong
2013-09-09 19:37 ` Hleb Valoshka [this message]
2013-09-09 19:44 ` Eric Wong
2013-09-09 20:35 ` Hleb Valoshka
2013-09-09 22:03 ` Eric Wong
2013-09-10 7:18 ` Hleb Valoshka
2016-02-25 9:54 ` Eric Wong
2014-11-14 3:15 ` [PATCH 1/2] Add setup and teardown for ipv6 tests Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/raindrops/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAB-KckpMYtQo3yeXAu1Su=Up+_g8vyU23DNPYBojwdtFCEy5A@mail.gmail.com' \
--to=375gnu@gmail.com \
--cc=raindrops@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/raindrops.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).