From: Brian Corrigan <brian@genexp.me>
To: raindrops@librelist.org
Subject: Re: [PATCH] ...
Date: Tue, 5 Jun 2012 19:59:21 -0400 [thread overview]
Message-ID: <CALO9HP0mwg54Eq_dHZw9T2oELMmpj3XEzJdrr3R2sk5XPsD3mg@mail.gmail.com> (raw)
In-Reply-To: 20120605175755.GA8749@dcvr.yhbt.net
Hey Eric - can you take it for here? Also, thanks for the patience :).
Fwiw, it's cool to have code in this project. I learned a lot by reviewing
the source.
On Tuesday, June 5, 2012, Eric Wong wrote:
> Brian Corrigan <brian@genexp.me <javascript:;>> wrote:
> > Subject: [PATCH] Raindrops currently fails when provided a
> > symlink to a socket. As this is a common practice for many deployment
> > tools (Vlad, etc.) this patch adds support for finding the realpath
> prior
> > to looking the socket up in /proc/net/unix
>
> Erhm, I meant write the commit message with a separate short Subject:
> line and body (like an email). Most of the existing commits in
> raindrops are written this way, and it's the standard for git.git.
>
> I can rewrite the commit message if you don't have time, the rest
> of the patch looks fine. Thanks!
>
next prev parent reply other threads:[~2012-06-05 23:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 15:46 [PATCH] Raindrops currently fails when provided a symlink to a socket. As this is a common practice for many deployment tools (Vlad, etc.) this patch adds support for finding the realpath prior to looking the socket up in /proc/net/unix Brian Corrigan
2012-06-05 17:57 ` [PATCH] Eric Wong
2012-06-05 23:59 ` Brian Corrigan [this message]
2012-06-06 0:15 ` [PATCH] Eric Wong
2012-06-06 0:49 ` [PATCH] Eric Wong
2012-06-06 0:50 ` [PATCH] Brian Corrigan
2012-06-06 0:56 ` [PATCH] unix_listener_stats follows and remembers symlinks Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/raindrops/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALO9HP0mwg54Eq_dHZw9T2oELMmpj3XEzJdrr3R2sk5XPsD3mg@mail.gmail.com \
--to=brian@genexp.me \
--cc=raindrops@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/raindrops.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).