[sleepy.penguin] [PATCH 2/2] inotify: thread-safe Inotify#take for rbx

[Eric Wong <normalperson@yhbt.net>]

Rubinius provides a Rubinius.synchronize helper for locking
objects which do not otherwise have locks.  We need to
synchronize Inotify#take access to prevent the internal array
from being clobbered.

This avoids unnecessary locking overhead on MRI which maintains
a GVL.
---
 lib/sleepy_penguin.rb | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/lib/sleepy_penguin.rb b/lib/sleepy_penguin.rb
index c13eb0c..1888e3b 100644
--- a/lib/sleepy_penguin.rb
+++ b/lib/sleepy_penguin.rb
@@ -6,3 +6,18 @@ module SleepyPenguin
 end
 require 'sleepy_penguin_ext'
 require 'sleepy_penguin/epoll'
+
+# :stopdoc:
+#
+# We need to serialize Inotify#take for Rubinius since that has no GVL
+# to protect the internal array
+if defined?(SleepyPenguin::Inotify) &&
+   defined?(Rubinius) && Rubinius.respond_to?(:synchronize)
+  class SleepyPenguin::Inotify
+    alias __take take
+    undef_method :take
+    def take(*args)
+      Rubinius.synchronize(@inotify_tmp) { __take(*args) }
+    end
+  end
+end
-- 
1.8.2.1.366.ge2af9e3