From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS47066 71.19.144.0/20 X-Spam-Status: No, score=-1.9 required=3.0 tests=AWL,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: normalperson@yhbt.net Received: from zedshaw2.xen.prgmr.com (zedshaw2.xen.prgmr.com [71.19.156.177]) by dcvr.yhbt.net (Postfix) with ESMTP id 5B4E11F701 for ; Tue, 30 Apr 2013 02:40:20 +0000 (UTC) Received: from zedshaw2.xen.prgmr.com (unknown [IPv6:::1]) by zedshaw2.xen.prgmr.com (Postfix) with ESMTP id BC26E73E01 for ; Tue, 30 Apr 2013 02:42:17 +0000 (UTC) MIME-Version: 1.0 Date: Tue, 30 Apr 2013 02:39:33 +0000 From: Eric Wong List-Archive: List-Help: List-Id: List-Post: List-Subscribe: List-Unsubscribe: Message-Id: <1367289582-31293-9-git-send-email-normalperson@yhbt.net> Precedence: list References: <1367289582-31293-1-git-send-email-normalperson@yhbt.net> Sender: sleepy.penguin@librelist.org Subject: [sleepy.penguin] [PATCH 08/17] kqueue: set zero timeout if not retrieving events To: sleepy.penguin@librelist.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Having a timeout does not make sense if not retrieving events, so avoid potentially triggering bugs or strange behavior between different kqueue implementations. --- ext/sleepy_penguin/kqueue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ext/sleepy_penguin/kqueue.c b/ext/sleepy_penguin/kqueue.c index 8e33592..78a13c3 100644 --- a/ext/sleepy_penguin/kqueue.c +++ b/ext/sleepy_penguin/kqueue.c @@ -317,6 +317,7 @@ static VALUE sp_kevent(int argc, VALUE *argv, VALUE self) rb_raise(rb_eArgError, "nevents specified but block not given"); nevents = 0; + timeout = INT2FIX(0); } kpt = kpt_get(self, nchanges, nevents); -- 1.8.2.1.367.gc875ca7