From: Eric Wong <e@80x24.org>
To: sleepy-penguin@bogomips.org
Subject: [PATCH] free buffer if pthread_setspecific fails
Date: Thu, 16 Mar 2017 19:45:55 +0000 [thread overview]
Message-ID: <20170316194555.11372-1-e@80x24.org> (raw)
Unlikely, but we must not leak memory if pthread_setspecific
somehow fails.
---
ext/sleepy_penguin/init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ext/sleepy_penguin/init.c b/ext/sleepy_penguin/init.c
index 01bb52f..f9671eb 100644
--- a/ext/sleepy_penguin/init.c
+++ b/ext/sleepy_penguin/init.c
@@ -113,6 +113,7 @@ void *rb_sp_gettlsbuf(size_t *size)
buf->capa = *size;
err = pthread_setspecific(rb_sp_key, buf);
if (err != 0) {
+ free(buf);
errno = err;
rb_sys_fail("BUG: pthread_setspecific");
}
--
EW
reply other threads:[~2017-03-16 19:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/sleepy_penguin/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316194555.11372-1-e@80x24.org \
--to=e@80x24.org \
--cc=sleepy-penguin@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/sleepy_penguin.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).