From: Eric Wong <e@80x24.org>
To: sleepy-penguin@bogomips.org
Subject: [PATCH] epoll: add newline to Kernel#warn messages for atomicity
Date: Fri, 17 Mar 2017 00:07:38 +0000 [thread overview]
Message-ID: <20170317000738.6401-1-e@80x24.org> (raw)
Relying on the record separator ($\ or "\n") is not atomic
on multi-process or multi-threaded systems writing to the
same log file or pipe.
---
lib/sleepy_penguin/epoll.rb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/sleepy_penguin/epoll.rb b/lib/sleepy_penguin/epoll.rb
index 637db8d..da1502e 100644
--- a/lib/sleepy_penguin/epoll.rb
+++ b/lib/sleepy_penguin/epoll.rb
@@ -166,7 +166,7 @@ class SleepyPenguin::Epoll
begin
@io.epoll_ctl(CTL_MOD, io, events)
rescue Errno::ENOENT
- warn "epoll event cache failed (mod -> add)"
+ warn "epoll event cache failed (mod -> add)\n"
@io.epoll_ctl(CTL_ADD, io, events)
@marks[fd] = io
end
@@ -174,7 +174,7 @@ class SleepyPenguin::Epoll
begin
@io.epoll_ctl(CTL_ADD, io, events)
rescue Errno::EEXIST
- warn "epoll event cache failed (add -> mod)"
+ warn "epoll event cache failed (add -> mod)\n"
@io.epoll_ctl(CTL_MOD, io, events)
end
@marks[fd] = io
--
EW
reply other threads:[~2017-03-17 0:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/sleepy_penguin/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317000738.6401-1-e@80x24.org \
--to=e@80x24.org \
--cc=sleepy-penguin@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/sleepy_penguin.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).