sleepy_penguin RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: "Lin Jen-Shin (godfat)" <godfat@godfat.org>
To: sleepy.penguin@librelist.org
Subject: [sleepy.penguin] Re: [PATCH] Add support for Mac OS X
Date: Mon, 26 Aug 2013 16:52:09 +0800	[thread overview]
Message-ID: <CAA2_N1vC3UPBrzWn43904rQj5aXiS=k8z-GPNP0h27oyg3ovXg@mail.gmail.com> (raw)
In-Reply-To: 1377506784-48542-1-git-send-email-godfat@godfat.org

On Mon, Aug 26, 2013 at 4:46 PM, Lin Jen-Shin <godfat@godfat.org> wrote:
> Since Mac OS X does not support clock_gettime, we need to wrap
> around clock_gettime to make kqueue work on Mac OS X.
>
> epoll.c does not need this wrapper as it's only on Linux,
> but I guess it's fine to use the wrapper as well. Maybe
> someday *BSD could also support epoll in someway?
[...]

Unfortunately, this looks like an intrusive patch that makes
calling clock_gettime not as straight as before (in terms of
code readability).

Feel free to not merge this then. I could totally understand it.


  reply	other threads:[~2013-08-26  8:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <godfat@godfat.org>
2013-08-26  8:46 ` [sleepy.penguin] [PATCH] Add support for Mac OS X Lin Jen-Shin
2013-08-26  8:52   ` Lin Jen-Shin (godfat) [this message]
2013-08-26  9:12   ` Eric Wong
2013-08-28 18:10     ` Lin Jen-Shin (godfat)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/sleepy_penguin/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA2_N1vC3UPBrzWn43904rQj5aXiS=k8z-GPNP0h27oyg3ovXg@mail.gmail.com' \
    --to=godfat@godfat.org \
    --cc=sleepy.penguin@librelist.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/sleepy_penguin.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).