From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-2.9 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: unicorn-public@bogomips.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id A8E8720376; Tue, 30 Jun 2015 22:52:03 +0000 (UTC) From: Eric Wong To: unicorn-public@bogomips.org Cc: e@80x24.org Subject: [PATCH 0/3] reflect changes to Rack::Utils::HTTP_STATUS_CODES Date: Tue, 30 Jun 2015 22:51:49 +0000 Message-Id: <1435704712-4981-1-git-send-email-e@80x24.org> List-Id: A user privately reported (to unicorn@bogomips.org) that they wanted status text reflected in their responses for an HTTP status code not included with Rack::Utils::HTTP_STATUS_CODES. They tried to modify Rack::Utils::HTTP_STATUS_CODES hash directly in their app, but unicorn loads before their app and already memoized the status codes internally in the CODES hash to reduce GC pressure, thus their change was never reflected. With the first change, users can change Rack::Utils::HTTP_STATUS_CODES as many times as they want (perhaps even based on time-of-day, weather, server load, whatever) and the changes will be reflected instantaneously in responses. Of course, this slows unicorn down slightly due to increased GC pressure, but I doubt anybody would notice in Real World usage. In case they do, patch 2/3 will recover the lost performance if they're using Ruby 2.2+ I figure anybody who cares about micro-benchmark performance with unicorn would be using the latest Rubies anyways... That user is Bcc:-ed for these patches, and can follow any public discussion at: http://bogomips.org/unicorn-public/ (including the Atom feed at http://bogomips.org/unicorn-public/atom.xml ) * [PATCH 1/3] reflect changes in Rack::Utils::HTTP_STATUS_CODES introduces a performance regression * [PATCH 2/3] reduce constants and optimize for Ruby 2.2 recover lost performance from [PATCH 1/3] (on Ruby 2.2+), further regressions for 2.1+ * [PATCH 3/3] http_response: reduce size of multi-line header path bonus reduce code size for common cases, should lib/unicorn/http_request.rb | 19 +++++++------------ lib/unicorn/http_response.rb | 23 ++++++++++------------- test/unit/test_response.rb | 20 ++++++++++++++++++++ 3 files changed, 37 insertions(+), 25 deletions(-)