From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=unavailable version=3.3.2 X-Original-To: unicorn-public@bogomips.org Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0E727659016 for ; Sat, 22 Aug 2015 04:42:50 +0000 (UTC) From: Eric Wong To: unicorn-public@bogomips.org Subject: [PATCH] stream_input: favor String#clear over String#replace Date: Sat, 22 Aug 2015 04:42:49 +0000 Message-Id: <1440218569-25476-1-git-send-email-e@80x24.org> List-Id: We no longer need Ruby 1.8 compatibility, so use String#clear to reduce argument passing and code size. --- lib/unicorn/stream_input.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/unicorn/stream_input.rb b/lib/unicorn/stream_input.rb index 9278f47..de5aeea 100644 --- a/lib/unicorn/stream_input.rb +++ b/lib/unicorn/stream_input.rb @@ -53,7 +53,7 @@ class Unicorn::StreamInput rv << @rbuf to_read -= @rbuf.size end - @rbuf.replace('') + @rbuf.clear end rv = nil if rv.empty? && length != 0 else @@ -130,8 +130,8 @@ private filter_body(@rbuf, @buf) dst << @rbuf end - ensure - @rbuf.replace('') + ensure + @rbuf.clear end def eof! -- EW