From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS14383 205.234.109.0/24 X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,MSGID_FROM_MTA_HEADER, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.unicorn.general Subject: Re: "unicorn -D" always returns 0 "success" (even when failed to load) Date: Mon, 28 Dec 2009 16:17:00 -0800 Message-ID: <20091229001700.GA25599@dcvr.yhbt.net> References: <200912260529.45530.ibc@aliax.net> <200912282117.28125.ibc@aliax.net> <20091228203259.GB23032@dcvr.yhbt.net> <200912282141.51953.ibc@aliax.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1262045923 6755 80.91.229.12 (29 Dec 2009 00:18:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Dec 2009 00:18:43 +0000 (UTC) To: unicorn list Original-X-From: mongrel-unicorn-bounces@rubyforge.org Tue Dec 29 01:18:36 2009 Return-path: Envelope-to: gclrug-mongrel-unicorn@m.gmane.org X-Original-To: mongrel-unicorn@rubyforge.org Delivered-To: mongrel-unicorn@rubyforge.org Content-Disposition: inline In-Reply-To: <200912282141.51953.ibc@aliax.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-BeenThere: mongrel-unicorn@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: mongrel-unicorn-bounces@rubyforge.org Errors-To: mongrel-unicorn-bounces@rubyforge.org Xref: news.gmane.org gmane.comp.lang.ruby.unicorn.general:274 Archived-At: Received: from rubyforge.org ([205.234.109.19]) by lo.gmane.org with esmtp (Exim 4.50) id 1NPPnH-00083a-LC for gclrug-mongrel-unicorn@m.gmane.org; Tue, 29 Dec 2009 01:18:35 +0100 Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id A02DB19782DC; Mon, 28 Dec 2009 19:18:33 -0500 (EST) Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by rubyforge.org (Postfix) with ESMTP id 695A7167830B for ; Mon, 28 Dec 2009 19:17:01 -0500 (EST) Received: from localhost (unknown [127.0.2.5]) by dcvr.yhbt.net (Postfix) with ESMTP id E04871F53D; Tue, 29 Dec 2009 00:17:00 +0000 (UTC) I=F1aki Baz Castillo wrote: > El Lunes, 28 de Diciembre de 2009, Eric Wong escribi=F3: > > I=F1aki Baz Castillo wrote: > > > El Lunes, 28 de Diciembre de 2009, Eric Wong escribi=F3: > > > > > As a suggestion, could the grandparent rescue such exception and > > > > > display some kind of error message?: > > > > > > > > > > "The master couldn't be started. Inspect the log error or run in > > > > > foreground" > > > > > > > > Thanks, pushed out to the ready_pipe branch of unicorn.git > > > > > > Hi, I attach a minor patch to make the error more verbose when Unicorn > > > cannot listen in a socket. > > = > > Hi, it seems like you didn't attach the patch. > = > Ops, usually my mail client (Kmail) warns me when I write tha word "attac= h" = > but attach nothing... not sure why it didn't it this time. > = > > Attaching patches is > > strongly discouraged, though, inline patches are far easier to > > review/edit/apply. > = > Ok, here it's (note that it's done over 'ready_pipe' branch): Thanks, applied with your name and pushed out to both ready_pipe and master in unicorn.git > --- unicorn.rb.orig 2009-12-28 21:02:47.000000000 +0100 > +++ unicorn.rb 2009-12-28 21:11:12.000000000 +0100 It should be easier to make a commit using git and then just "git format-patch -M" to output it, proposed commit message and all. In the HACKING doc, I've been recommending people follow the SubmittingPatches document distributed with git when submitting patches to Unicorn: http://git.bogomips.org/cgit/mirrors/git.git/tree/Documentation/Submitting= Patches -- = Eric Wong _______________________________________________ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying