From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS14383 205.234.109.0/24 X-Spam-Status: No, score=-0.5 required=5.0 tests=AWL,MSGID_FROM_MTA_HEADER, RP_MATCHES_RCVD shortcircuit=no autolearn=unavailable version=3.3.2 Path: news.gmane.org!not-for-mail From: Eric Wong Newsgroups: gmane.comp.lang.ruby.unicorn.general Subject: Re: Suggestion for reload action (USR2) Date: Wed, 20 Jan 2010 20:03:43 +0000 Message-ID: <20100120200343.GA9925@dcvr.yhbt.net> References: <201001201020.23413.ibc@aliax.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1264017883 24265 80.91.229.12 (20 Jan 2010 20:04:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jan 2010 20:04:43 +0000 (UTC) To: unicorn list Original-X-From: mongrel-unicorn-bounces@rubyforge.org Wed Jan 20 21:04:34 2010 Return-path: Envelope-to: gclrug-mongrel-unicorn@m.gmane.org X-Original-To: mongrel-unicorn@rubyforge.org Delivered-To: mongrel-unicorn@rubyforge.org Content-Disposition: inline In-Reply-To: <201001201020.23413.ibc@aliax.net> User-Agent: Mutt/1.5.18 (2008-05-17) X-BeenThere: mongrel-unicorn@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: mongrel-unicorn-bounces@rubyforge.org Errors-To: mongrel-unicorn-bounces@rubyforge.org Xref: news.gmane.org gmane.comp.lang.ruby.unicorn.general:364 Archived-At: Received: from rubyforge.org ([205.234.109.19]) by lo.gmane.org with esmtp (Exim 4.50) id 1NXgn3-0002D2-4m for gclrug-mongrel-unicorn@m.gmane.org; Wed, 20 Jan 2010 21:04:33 +0100 Received: from rubyforge.org (rubyforge.org [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 0D13E18582DC; Wed, 20 Jan 2010 15:04:34 -0500 (EST) Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by rubyforge.org (Postfix) with ESMTP id A27A218582D2 for ; Wed, 20 Jan 2010 15:03:44 -0500 (EST) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPSA id 0BFC81F507; Wed, 20 Jan 2010 20:03:44 +0000 (UTC) I=F1aki Baz Castillo wrote: > El Mi=E9rcoles, 20 de Enero de 2010, I=F1aki Baz Castillo escribi=F3: > = > > This would involve just three changes: > > = > > - Add an option "--reload" in OptionParser in bin/unicorn. > > - Store such option somewhere so it can be readed later by the Rack > > application or other library. > > - Add "--reload" to the list of original arguments when receiving USR2. Hi I=F1aki, All you need to do is to check for the presence of ENV["UNICORN_FD"] which is used to communicate file descriptor numbers for the upgrade process > I attach a patch (for master branch) that would do the job (except the = > fact that I don't know how to store the "reload" option): > (unfortunatelly I cannot attach files in this mailist as the mail is = > rejected). While the patch was not needed for this case, inline patches are strongly preferred here. Inline patches are far easier to read, reply-to and apply than attachments. -- = Eric Wong _______________________________________________ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying