unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* leading/trailing linear whitespace in headers
@ 2011-05-21  3:05 Eric Wong
  2011-05-21  5:14 ` Lawrence Pit
  0 siblings, 1 reply; 6+ messages in thread
From: Eric Wong @ 2011-05-21  3:05 UTC (permalink / raw)
  To: mongrel-unicorn

I thought I posted this here, but apparently not :x

There's an bug in how we preserve trailing whitespace in headers
that'll be fixed in the next release (probably 3.7.0 next week).

This may break some applications that rely on the current buggy
behavior, but I haven't heard of it and I'm a bit surprised I'm the
first one to notice it after all this time.

My original post to the mongrel-development mailing list is here:

http://mid.gmane.org/20110518211349.GA677@dcvr.yhbt.net

-- 
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: leading/trailing linear whitespace in headers
  2011-05-21  3:05 leading/trailing linear whitespace in headers Eric Wong
@ 2011-05-21  5:14 ` Lawrence Pit
  2011-05-21  5:57   ` Eric Wong
  0 siblings, 1 reply; 6+ messages in thread
From: Lawrence Pit @ 2011-05-21  5:14 UTC (permalink / raw)
  To: unicorn list

Hi Eric,

Since I upgraded from unicorn 1 to 3, Unicorn will freeze for 60 seconds 
at random moments, and then restart. Only on my dev machine. Not in 1 
project, but in all my projects that use unicorn. I get no log output, 
it just freezes for 60 seconds. Strangely this happens significantly 
more often with using Chrome as a client than with Firefox.

So I hope this will fix that, though I have no idea if it's related in 
any way.  I was thinking it may also have to do with unicorn not 
officially supporting Mac OS X.


Cheers,
Lawrence

> I thought I posted this here, but apparently not :x
>
> There's an bug in how we preserve trailing whitespace in headers
> that'll be fixed in the next release (probably 3.7.0 next week).
>
> This may break some applications that rely on the current buggy
> behavior, but I haven't heard of it and I'm a bit surprised I'm the
> first one to notice it after all this time.
>
> My original post to the mongrel-development mailing list is here:
>
> http://mid.gmane.org/20110518211349.GA677@dcvr.yhbt.net
>

_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: leading/trailing linear whitespace in headers
  2011-05-21  5:14 ` Lawrence Pit
@ 2011-05-21  5:57   ` Eric Wong
  2011-05-27  7:32     ` Lawrence Pit
  0 siblings, 1 reply; 6+ messages in thread
From: Eric Wong @ 2011-05-21  5:57 UTC (permalink / raw)
  To: unicorn list

Lawrence Pit <lawrence.pit@gmail.com> wrote:
> Hi Eric,
> 
> Since I upgraded from unicorn 1 to 3, Unicorn will freeze for 60
> seconds at random moments, and then restart. Only on my dev machine.
> Not in 1 project, but in all my projects that use unicorn. I get no
> log output, it just freezes for 60 seconds. Strangely this happens
> significantly more often with using Chrome as a client than with
> Firefox.

Even through nginx?  Which Ruby version is it?

The bug I'm referring to in this thread is only for /request/ headers,
and I don't think any common HTTP clients send trailing whitespace.

> So I hope this will fix that, though I have no idea if it's related
> in any way.  I was thinking it may also have to do with unicorn not
> officially supporting Mac OS X.

I'm sure you're not the only OS X Unicorn user, perhaps somebody else
knows what's going on...

If it's kgio-related, but I think Jeremy fixed all the issues under
OpenBSD with kgio 2.4.0 and some of that probably helped other
*BSD-based systems.  I've been meaning to setup a VM on FreeBSD
again but haven't had the time.

-- 
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: leading/trailing linear whitespace in headers
  2011-05-21  5:57   ` Eric Wong
@ 2011-05-27  7:32     ` Lawrence Pit
  2011-05-30  7:02       ` Lawrence Pit
  0 siblings, 1 reply; 6+ messages in thread
From: Lawrence Pit @ 2011-05-27  7:32 UTC (permalink / raw)
  To: unicorn list

Hi Eric,

I thought I'll wait a few days before replying just to make sure: 
believe it or not, since I upgraded 4 days ago to kgio 2.4.1 not once 
did I run into this issue. While before that unicorn would timeout at 
least once every hour, sometimes a dozen times in a row.

I don't run through nginx on my dev machine, just straight into 
unicorn_rails using mostly Chrome 11 and FF 4. I use:

ruby 1.8.7 (2010-04-19 patchlevel 253) [i686-darwin10.4.0], MBARI 
0x6770, Ruby Enterprise Edition 2010.02



Cheers,
Lawrence

> Hi Eric,
>> Since I upgraded from unicorn 1 to 3, Unicorn will freeze for 60
>> seconds at random moments, and then restart. Only on my dev machine.
>> Not in 1 project, but in all my projects that use unicorn. I get no
>> log output, it just freezes for 60 seconds. Strangely this happens
>> significantly more often with using Chrome as a client than with
>> Firefox.
> Even through nginx?  Which Ruby version is it?
>
> The bug I'm referring to in this thread is only for /request/ headers,
> and I don't think any common HTTP clients send trailing whitespace.
>
>> So I hope this will fix that, though I have no idea if it's related
>> in any way.  I was thinking it may also have to do with unicorn not
>> officially supporting Mac OS X.
> I'm sure you're not the only OS X Unicorn user, perhaps somebody else
> knows what's going on...
>
> If it's kgio-related, but I think Jeremy fixed all the issues under
> OpenBSD with kgio 2.4.0 and some of that probably helped other
> *BSD-based systems.  I've been meaning to setup a VM on FreeBSD
> again but haven't had the time.
>

_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: leading/trailing linear whitespace in headers
  2011-05-27  7:32     ` Lawrence Pit
@ 2011-05-30  7:02       ` Lawrence Pit
  2011-05-31  4:49         ` Eric Wong
  0 siblings, 1 reply; 6+ messages in thread
From: Lawrence Pit @ 2011-05-30  7:02 UTC (permalink / raw)
  To: unicorn list


Cheered too early after all, just got one again:

E, [2011-05-30T16:59:36.005000 #7351] ERROR -- : worker=0 PID:7352 
timeout (60.004931s > 60s), killing
E, [2011-05-30T16:59:36.058276 #7351] ERROR -- : reaped 
#<Process::Status: pid=7352,signaled(SIGKILL=9)> worker=0
I, [2011-05-30T16:59:36.059122 #7351]  INFO -- : worker=0 spawning...
I, [2011-05-30T16:59:36.062990 #8505]  INFO -- : worker=0 spawned pid=8505
I, [2011-05-30T16:59:36.063395 #8505]  INFO -- : Refreshing Gem list
=> ruby 1.8.7 (i686-darwin10.4.0) [2010-04-19] Ruby Enterprise Edition
worker=0 ready



Cheers,
Lawrence

> Hi Eric,
>
> I thought I'll wait a few days before replying just to make sure: 
> believe it or not, since I upgraded 4 days ago to kgio 2.4.1 not once 
> did I run into this issue. While before that unicorn would timeout at 
> least once every hour, sometimes a dozen times in a row.
>
> I don't run through nginx on my dev machine, just straight into 
> unicorn_rails using mostly Chrome 11 and FF 4. I use:
>
> ruby 1.8.7 (2010-04-19 patchlevel 253) [i686-darwin10.4.0], MBARI 
> 0x6770, Ruby Enterprise Edition 2010.02
>
>
>
> Cheers,
> Lawrence
>
>> Hi Eric,
>>> Since I upgraded from unicorn 1 to 3, Unicorn will freeze for 60
>>> seconds at random moments, and then restart. Only on my dev machine.
>>> Not in 1 project, but in all my projects that use unicorn. I get no
>>> log output, it just freezes for 60 seconds. Strangely this happens
>>> significantly more often with using Chrome as a client than with
>>> Firefox.
>> Even through nginx?  Which Ruby version is it?
>>
>> The bug I'm referring to in this thread is only for /request/ headers,
>> and I don't think any common HTTP clients send trailing whitespace.
>>
>>> So I hope this will fix that, though I have no idea if it's related
>>> in any way.  I was thinking it may also have to do with unicorn not
>>> officially supporting Mac OS X.
>> I'm sure you're not the only OS X Unicorn user, perhaps somebody else
>> knows what's going on...
>>
>> If it's kgio-related, but I think Jeremy fixed all the issues under
>> OpenBSD with kgio 2.4.0 and some of that probably helped other
>> *BSD-based systems.  I've been meaning to setup a VM on FreeBSD
>> again but haven't had the time.
>>
>

_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: leading/trailing linear whitespace in headers
  2011-05-30  7:02       ` Lawrence Pit
@ 2011-05-31  4:49         ` Eric Wong
  0 siblings, 0 replies; 6+ messages in thread
From: Eric Wong @ 2011-05-31  4:49 UTC (permalink / raw)
  To: Lawrence Pit; +Cc: unicorn list

Lawrence Pit <lawrence.pit@gmail.com> wrote:
> Cheered too early after all, just got one again:

Can you ever reproduce this with nginx in front?  Does anybody else
on any *BSD platform get this?

Btw, please don't waste my bandwidth top posting, I'd rather people
not quote at all than top post, thanks!

-- 
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-05-31  5:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-21  3:05 leading/trailing linear whitespace in headers Eric Wong
2011-05-21  5:14 ` Lawrence Pit
2011-05-21  5:57   ` Eric Wong
2011-05-27  7:32     ` Lawrence Pit
2011-05-30  7:02       ` Lawrence Pit
2011-05-31  4:49         ` Eric Wong

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).