From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS33070 50.56.128.0/17 X-Spam-Status: No, score=0.5 required=5.0 tests=AWL,RDNS_NONE shortcircuit=no autolearn=no version=3.3.2 X-Original-To: archivist@yhbt.net Delivered-To: archivist@dcvr.yhbt.net Received: from rubyforge.org (unknown [50.56.192.79]) by dcvr.yhbt.net (Postfix) with ESMTP id D39601FDEB for ; Fri, 1 Nov 2013 16:53:59 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by rubyforge.org (Postfix) with ESMTP id 683792E1DF; Fri, 1 Nov 2013 16:54:00 +0000 (UTC) X-Original-To: mongrel-unicorn@rubyforge.org Delivered-To: mongrel-unicorn@rubyforge.org Received: from dcvr.yhbt.net (dcvr.yhbt.net [64.71.152.64]) by rubyforge.org (Postfix) with ESMTP id D286F2E2CE for ; Fri, 1 Nov 2013 16:50:04 +0000 (UTC) Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id F182E1FD5B; Fri, 1 Nov 2013 16:50:02 +0000 (UTC) Date: Fri, 1 Nov 2013 16:50:02 +0000 From: Eric Wong To: unicorn list Subject: Re: [PATCH] construct listener_fds Hash in 1.8 compatible way Message-ID: <20131101165002.GA2425@dcvr.yhbt.net> References: <5273c853.0575320a.4f74.ffffaae6@mx.google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5273c853.0575320a.4f74.ffffaae6@mx.google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: mongrel-unicorn@rubyforge.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: mongrel-unicorn-bounces@rubyforge.org Errors-To: mongrel-unicorn-bounces@rubyforge.org "Ernest W. Durbin III" wrote: > This renables the ability for Ruby 1.8 environments to perform reexecs Is this for Ruby 1.8.6? I've only tested on 1.8.7, I haven't had a 1.8.6 installation in a while. > --- a/lib/unicorn/http_server.rb > +++ b/lib/unicorn/http_server.rb > @@ -449,13 +449,14 @@ class Unicorn::HttpServer > end > > self.reexec_pid = fork do > - listener_fds = Hash[LISTENERS.map do |sock| > + listener_fds = Hash.new listener_fds = {} is generally preferred unless there's a default value. I'll apply the edited change if that's alright with you (and update the commit message for 1.8.6 support). Thanks! _______________________________________________ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying