unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: unblock function in pg messes up with unicorn
Date: Fri, 6 Dec 2013 18:48:49 +0000	[thread overview]
Message-ID: <20131206184849.GA27820@dcvr.yhbt.net> (raw)
In-Reply-To: <CAAtdryPgc3N6N6kTJaNpYJb5VNvdtROd+37Pc3Z4PQUBssc39g@mail.gmail.com>

Sam Saffron <sam.saffron@gmail.com> wrote:
> 1. Is this a pg bug? How could they even implement a ubf in such a way
> that it does not stop queries when signals are sent? The main issue is
> that without this Thread.kill will have to wait for queries to finish.

No, not a pg bug.  pg needs to account for the user hitting Ctrl-C and
wanting to cancel a query (oh-no-I-started-DELETE-without-WHERE!).

> 2. Is this a ruby bug? should there be a more sophisticated protocol
> here? Should trap handlers inform the runtime that a ubf is not
> needed?

I don't know.  Something like: trap(:QUIT, no_ubf: true) { ... }  ?

> something else ?

Also see http://mid.gmane.org/20131120094717.GA17836@dcvr.yhbt.net

Btw, given the master <-> worker separation in unicorn, we can also
have the master talk to the worker through a pipe and avoid signals
between the two.

> Similar issue exists in mysql afaik.

I don't think the mysql2 gem currently interrupts running queries.
Not sure about the others.
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

  reply	other threads:[~2013-12-06 18:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 12:29 unblock function in pg messes up with unicorn Sam Saffron
2013-12-06 18:48 ` Eric Wong [this message]
2013-12-07  0:04   ` Sam Saffron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131206184849.GA27820@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).