unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Valentin Mihov <valentin.mihov@gmail.com>
Cc: "Bráulio Bhavamitra" <braulio@eita.org.br>,
	unicorn-public <unicorn-public@bogomips.org>
Subject: Re: Master hooks needed
Date: Fri, 3 Oct 2014 17:50:42 +0000	[thread overview]
Message-ID: <20141003175042.GA30986@dcvr.yhbt.net> (raw)
In-Reply-To: <CAC=mCcmx1yTiU0XRP+gDJ7qHECEK9GT7ZOK57bbDG3K-OX6H4Q@mail.gmail.com>

Valentin Mihov <valentin.mihov@gmail.com> wrote:
> On Fri, Oct 3, 2014 at 3:22 PM, Eric Wong <e@80x24.org> wrote:
> > Bráulio Bhavamitra <braulio@eita.org.br> wrote:
> > > Both operations I currently do (server warm up and old pid kill) need
> > > to be run only once, and not for every worker as before_fork does,
> > > that's why I had to put the condition seen above.
> >
> > rack.git also has a Rack::Builder#warmup method.  Aman originally
> > proposed it for unicorn, but it's useful outside of unicorn so
> > we moved it to Rack.
> Isn't it much better to do the warmup in an initializer instead in
> unicorn? This way you can preload_app=true and the master will execute
> the warmup code and fork. Killing the old pid is probably stopping you
> from do that, right?

Right, that's exactly what Rack::Builder#warmup does with
preload_app=true.  If by "initializer" you mean within the application,
the problem was it lacked the visibility of the entire Rack middleware
stack which Rack::Builder has.


  reply	other threads:[~2014-10-03 17:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 11:34 Master hooks needed Bráulio Bhavamitra
2014-10-03 12:22 ` Eric Wong
2014-10-03 12:36   ` Valentin Mihov
2014-10-03 17:50     ` Eric Wong [this message]
2014-10-03 18:12       ` Valentin Mihov
2014-10-04  0:53   ` Bráulio Bhavamitra
2014-10-04  1:22     ` Eric Wong
2014-10-04  1:35       ` Bráulio Bhavamitra
2014-10-04  1:57         ` Eric Wong
2014-10-04  2:04           ` Bráulio Bhavamitra
2014-10-04  2:25             ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141003175042.GA30986@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=braulio@eita.org.br \
    --cc=unicorn-public@bogomips.org \
    --cc=valentin.mihov@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).