unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* dropping Ruby 1.8 support for unicorn 5?
@ 2014-09-27  8:32 Eric Wong
  2014-09-27  8:37 ` Ernest W. Durbin III
  2014-10-18 21:39 ` Eric Wong
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Wong @ 2014-09-27  8:32 UTC (permalink / raw)
  To: unicorn-public

We've brought this up a few times, but I suppose we might as well drop
1.8 support in a major version change.

We may still maintain unicorn 4.x for 1.8 users indefinitely; after all,
we only accepted a patch for 1.8.6 compatibility less than a year
ago(!)[1].   So I'll still feel a _little_ bad for dropping 1.8 :x

One big reason for this is it looks like Ruby will move towards
deprecating old Data_* macros for superior (1.9+-only) TypedData_*
macros in the next few years[2].  The theme for unicorn 5 is mostly
dropping old, unused crap anyways; and not gaining new bloat.

Worst case is we support 1.8 and avoid deprecation warnings through
the use of ifdefs in the HTTP parser, but I'm no fan of ifdefs.


[1] commit 7e9e4c740aba24096f768f578779dc1053cb8b70
    (construct listener_fds Hash in 1.8.6 compatible way)

[2] http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=47717
    This is due to type-checking issues like
    https://bugs.ruby-lang.org/issues/10296

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: dropping Ruby 1.8 support for unicorn 5?
  2014-09-27  8:32 dropping Ruby 1.8 support for unicorn 5? Eric Wong
@ 2014-09-27  8:37 ` Ernest W. Durbin III
  2014-10-18 21:39 ` Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Ernest W. Durbin III @ 2014-09-27  8:37 UTC (permalink / raw)
  To: Eric Wong; +Cc: unicorn-public

[-- Attachment #1: Type: text/plain, Size: 1404 bytes --]

As the submitter of the referenced 1.8.6 patch *still ashamed* I can say that I fully support a 4.x series with “maintenance” level support.

Since the language won’t be changing, the 4.x series should be a very quiet branch indeed.

Onward, to greater things.

-Ernest

On Sep 27, 2014, at 4:32 AM, Eric Wong <e@80x24.org> wrote:

> We've brought this up a few times, but I suppose we might as well drop
> 1.8 support in a major version change.
> 
> We may still maintain unicorn 4.x for 1.8 users indefinitely; after all,
> we only accepted a patch for 1.8.6 compatibility less than a year
> ago(!)[1].   So I'll still feel a _little_ bad for dropping 1.8 :x
> 
> One big reason for this is it looks like Ruby will move towards
> deprecating old Data_* macros for superior (1.9+-only) TypedData_*
> macros in the next few years[2].  The theme for unicorn 5 is mostly
> dropping old, unused crap anyways; and not gaining new bloat.
> 
> Worst case is we support 1.8 and avoid deprecation warnings through
> the use of ifdefs in the HTTP parser, but I'm no fan of ifdefs.
> 
> 
> [1] commit 7e9e4c740aba24096f768f578779dc1053cb8b70
>    (construct listener_fds Hash in 1.8.6 compatible way)
> 
> [2] http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=47717
>    This is due to type-checking issues like
>    https://bugs.ruby-lang.org/issues/10296
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: dropping Ruby 1.8 support for unicorn 5?
  2014-09-27  8:32 dropping Ruby 1.8 support for unicorn 5? Eric Wong
  2014-09-27  8:37 ` Ernest W. Durbin III
@ 2014-10-18 21:39 ` Eric Wong
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Wong @ 2014-10-18 21:39 UTC (permalink / raw)
  To: unicorn-public

On a related note, I hope nobody is still on Ruby 1.9.1 or (shudder)
1.9.0.

I'd like to use require_relative; a 1.9.2+ feature and 1.9.2 is already
EOL these days.  I think there's still many 1.9.3 users out there, so we
need to continue supporting that for a while.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-18 21:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-27  8:32 dropping Ruby 1.8 support for unicorn 5? Eric Wong
2014-09-27  8:37 ` Ernest W. Durbin III
2014-10-18 21:39 ` Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../unicorn.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).