From: Eric Wong <e@80x24.org>
To: unicorn-public@bogomips.org
Cc: Steven Stewart-Gallus <sstewartgallus00@mylangara.bc.ca>,
Jesse Storimer <jstorimer@gmail.com>
Subject: [PATCH] explain 11 byte magic number for self-pipe
Date: Wed, 18 Feb 2015 09:36:00 +0000 [thread overview]
Message-ID: <20150218093600.GA30065@dcvr.yhbt.net> (raw)
Oops, this should've been explained long ago but apparently not.
In response to a comment on
http://www.sitepoint.com/the-self-pipe-trick-explained/
> Does anybody know why both unicorn and foreman read 11 bytes from
> self-pipe?
Unfortunately I couldn't find a way to comment on the site on a
JavaScript-free browser nor does it seem possible without
registering.
Again, anybody can send plain-text mail to:
unicorn-public@bogomips.org
No registration, no real name policy, no terms-of-service, just
plain-text. Feel free to use Tor, mixmaster or any anonymity
service, too.
---
lib/unicorn/http_server.rb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb
index 015bd94..683eb82 100644
--- a/lib/unicorn/http_server.rb
+++ b/lib/unicorn/http_server.rb
@@ -370,6 +370,10 @@ class Unicorn::HttpServer
# wait for a signal hander to wake us up and then consume the pipe
def master_sleep(sec)
IO.select([ @self_pipe[0] ], nil, nil, sec) or return
+ # 11 bytes is the maximum string length which can be embedded within
+ # the Ruby itself and not require a separate malloc (on 32-bit MRI 1.9+).
+ # Most reads are only one byte here and uncommon, so it's not worth a
+ # persistent buffer, either:
@self_pipe[0].kgio_tryread(11)
end
--
EW
reply other threads:[~2015-02-18 9:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218093600.GA30065@dcvr.yhbt.net \
--to=e@80x24.org \
--cc=jstorimer@gmail.com \
--cc=sstewartgallus00@mylangara.bc.ca \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).