unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [PATCH] tee_input: simplify condition for IO#write
@ 2017-02-10 19:12 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-02-10 19:12 UTC (permalink / raw)
  To: unicorn-public

IO#write already elides the write(2) syscall for empty buffers,
so there's no need to complicate our instruction sequence
footprint for the rare case of an empty buffer.

The only cases a Rack app will have an empty buffer are:

1) `env['rack.input'].read` without args
2) `env['rack.input'].gets`

Neither of these calls are safe for server-independent Rack apps
as the client can OOM the app.

unicorn itself provides no facility for limiting maximum
rack.input size.  Instead, unicorn relies on nginx to limit
input size using the client_max_body_size directive.
---
 lib/unicorn/tee_input.rb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/unicorn/tee_input.rb b/lib/unicorn/tee_input.rb
index 3c6d18a..6f66162 100644
--- a/lib/unicorn/tee_input.rb
+++ b/lib/unicorn/tee_input.rb
@@ -125,9 +125,7 @@ def consume!
   end
 
   def tee(buffer)
-    if buffer && buffer.size > 0
-      @tmp.write(buffer)
-    end
+    @tmp.write(buffer) if buffer
     buffer
   end
 end
-- 
EW


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-02-10 19:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-10 19:12 [PATCH] tee_input: simplify condition for IO#write Eric Wong

Code repositories for project(s) associated with this inbox:

	../../../unicorn.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).