From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 20676201A9; Tue, 21 Feb 2017 21:38:09 +0000 (UTC) Date: Tue, 21 Feb 2017 21:38:08 +0000 From: Eric Wong To: Jeremy Evans Cc: unicorn-public@bogomips.org Subject: Re: Patch: Add after_worker_exit configuration option Message-ID: <20170221213808.GA12779@whir> References: <20170221191923.GH93742@jeremyevans.local> <20170221194320.GA26617@whir> <20170221200216.GJ93742@jeremyevans.local> <20170221201526.GA7035@starla> <20170221204920.GL93742@jeremyevans.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170221204920.GL93742@jeremyevans.local> List-Id: Jeremy Evans wrote: > Here's a revised patch that should address the issues you identified: Thanks. Pushed as 2af91a1fef70d6546ee03760011c170a082db667 I needed one change to an integration test to workaround the lack of reader attribute, but I'd rather pay the cost in the test than the server, itself: https://bogomips.org/unicorn.git/patch?id=2c6aa5878d052abb ("t/t0012-reload-empty-config.sh: access ivars directly if needed")