From: Eric Wong <e@80x24.org>
To: Simon Eskildsen <simon.eskildsen@shopify.com>
Cc: unicorn-public@bogomips.org, Aman Gupta <aman@tmm1.net>
Subject: Re: [PATCH] check_client_connection: use tcp state on linux
Date: Wed, 8 Mar 2017 00:26:08 +0000 [thread overview]
Message-ID: <20170308002608.GA382@whir> (raw)
In-Reply-To: <20170307225045.GA19463@whir>
Eric Wong <e@80x24.org> wrote:
> Simon Eskildsen <simon.eskildsen@shopify.com> wrote:
> > @@ -28,6 +29,7 @@ class Unicorn::HttpParser
> > # Drop these frozen strings when Ruby 2.2 becomes more prevalent,
> > # 2.2+ optimizes hash assignments when used with literal string keys
> > HTTP_RESPONSE_START = [ 'HTTP', '/1.1 ']
> > + EMPTY_ARRAY = [].freeze
>
> (minor) this was made before commit e06b699683738f22
> ("http_request: freeze constant strings passed IO#write")
> but I've trivially fixed it up, locally.
And I actually screwed it up, pushed out ccc-tcp-v2 branch
with that fix squashed in :x
Writing tests, now...
next prev parent reply other threads:[~2017-03-08 0:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 14:03 [PATCH] check_client_connection: use tcp state on linux Simon Eskildsen
2017-02-25 16:19 ` Simon Eskildsen
2017-02-25 23:12 ` Eric Wong
2017-02-27 11:44 ` Simon Eskildsen
2017-02-28 21:12 ` Eric Wong
2017-03-01 3:18 ` Eric Wong
2017-03-06 21:32 ` Simon Eskildsen
2017-03-07 22:50 ` Eric Wong
2017-03-08 0:26 ` Eric Wong [this message]
2017-03-08 12:06 ` Simon Eskildsen
2017-03-13 20:16 ` Simon Eskildsen
2017-03-13 20:37 ` Eric Wong
2017-03-14 16:14 ` Simon Eskildsen
2017-03-14 16:41 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308002608.GA382@whir \
--to=e@80x24.org \
--cc=aman@tmm1.net \
--cc=simon.eskildsen@shopify.com \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).