From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 030AE1FBEC; Wed, 8 Mar 2017 00:26:08 +0000 (UTC) Date: Wed, 8 Mar 2017 00:26:08 +0000 From: Eric Wong To: Simon Eskildsen Cc: unicorn-public@bogomips.org, Aman Gupta Subject: Re: [PATCH] check_client_connection: use tcp state on linux Message-ID: <20170308002608.GA382@whir> References: <20170225231243.GA6224@dcvr.yhbt.net> <20170228211254.GA3868@whir> <20170301031828.GA19430@dcvr> <20170307225045.GA19463@whir> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170307225045.GA19463@whir> List-Id: Eric Wong wrote: > Simon Eskildsen wrote: > > @@ -28,6 +29,7 @@ class Unicorn::HttpParser > > # Drop these frozen strings when Ruby 2.2 becomes more prevalent, > > # 2.2+ optimizes hash assignments when used with literal string keys > > HTTP_RESPONSE_START = [ 'HTTP', '/1.1 '] > > + EMPTY_ARRAY = [].freeze > > (minor) this was made before commit e06b699683738f22 > ("http_request: freeze constant strings passed IO#write") > but I've trivially fixed it up, locally. And I actually screwed it up, pushed out ccc-tcp-v2 branch with that fix squashed in :x Writing tests, now...