unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Simon Eskildsen <simon.eskildsen@shopify.com>
Cc: unicorn-public@bogomips.org, raindrops-public@bogomips.org,
	Jeremy Evans <code@jeremyevans.net>
Subject: Re: [PATCH (ccc)] http_request: support proposed Raindrops::TCP states on
Date: Tue, 21 Mar 2017 08:19:23 +0000	[thread overview]
Message-ID: <20170321081923.GA4319@starla> (raw)
In-Reply-To: <CAO3HKM6eho0bfW4iGy1VFnywgGvT_zRUGowGv3RMrxU076BO7Q@mail.gmail.com>

Simon Eskildsen <simon.eskildsen@shopify.com> wrote:
> This looks good to me.

Thanks for taking a look.

> Only question is, why not make Raindrops 0.18+ a requirement to avoid
> the Raindrops.const_defined?(:TCP)?

I'd rather have some wiggle room in case problems are found on
either side; so people can rollback one without affecting the

It also relaxes things for distro packagers for coordinating
releases; in case there's other dependencies (whether human or
technical) which slow down the process.

(*) We may drop raindrops as a hard requirement for unicorn at
    some point, too.  The intended use case for counter sharing
    across hundredes/thousands of workers on massively multicore
    CPUs never surfaced.

  reply	other threads:[~2017-03-21  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170316031652.17433-1-e@80x24.org>
2017-03-21  2:55 ` [PATCH (ccc)] http_request: support proposed Raindrops::TCP states on Eric Wong
2017-03-21  7:50   ` Simon Eskildsen
2017-03-21  8:19     ` Eric Wong [this message]
2017-03-21 18:48   ` Jeremy Evans
2017-03-21 19:12     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321081923.GA4319@starla \
    --to=e@80x24.org \
    --cc=code@jeremyevans.net \
    --cc=raindrops-public@bogomips.org \
    --cc=simon.eskildsen@shopify.com \
    --cc=unicorn-public@bogomips.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).