From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 5B7CA20323; Tue, 21 Mar 2017 08:19:23 +0000 (UTC) Date: Tue, 21 Mar 2017 08:19:23 +0000 From: Eric Wong To: Simon Eskildsen Cc: unicorn-public@bogomips.org, raindrops-public@bogomips.org, Jeremy Evans Subject: Re: [PATCH (ccc)] http_request: support proposed Raindrops::TCP states on Message-ID: <20170321081923.GA4319@starla> References: <20170316031652.17433-1-e@80x24.org> <20170321025554.GA15807@starla> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Id: Simon Eskildsen wrote: > This looks good to me. Thanks for taking a look. > Only question is, why not make Raindrops 0.18+ a requirement to avoid > the Raindrops.const_defined?(:TCP)? I'd rather have some wiggle room in case problems are found on either side; so people can rollback one without affecting the other(*). It also relaxes things for distro packagers for coordinating releases; in case there's other dependencies (whether human or technical) which slow down the process. (*) We may drop raindrops as a hard requirement for unicorn at some point, too. The intended use case for counter sharing across hundredes/thousands of workers on massively multicore CPUs never surfaced.