unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [PATCH] test_exec: SO_KEEPALIVE value only needs to be true (take #2)
@ 2017-03-27 22:36 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-03-27 22:36 UTC (permalink / raw)
  To: unicorn-public

We need to ensure the portability of the sd_listen_fds emulation
test, too, which didn't get tested on my FreeBSD 10.3 install
due to it being on Ruby 2.2

Followup-to: 4ce6b00f75f1 ("test_exec: SO_KEEPALIVE value only needs to be true")
 test/exec/test_exec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/exec/test_exec.rb b/test/exec/test_exec.rb
index 08f92ae..9723c5c 100644
--- a/test/exec/test_exec.rb
+++ b/test/exec/test_exec.rb
@@ -122,7 +122,7 @@ def test_sd_listen_fds_emulation
       res = hit(["http://#@addr:#@port/"])
       assert_equal [ "HI\n" ], res
-      assert_equal 1, sock.getsockopt(:SOL_SOCKET, :SO_KEEPALIVE).int,
+      assert sock.getsockopt(:SOL_SOCKET, :SO_KEEPALIVE).bool,
                   'unicorn should always set SO_KEEPALIVE on inherited sockets'

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-27 22:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-27 22:36 [PATCH] test_exec: SO_KEEPALIVE value only needs to be true (take #2) Eric Wong

Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).