From: Jeremy Evans <code@jeremyevans.net>
To: Eric Wong <e@80x24.org>
Cc: Pere Joan Martorell <pere.joan@camaloon.com>,
unicorn-public@bogomips.org,
Philip Cunningham <philip@irisconnect.co.uk>,
Jonathan del Strother <maillist@steelskies.com>
Subject: Re: Random crash when sending USR2 + QUIT signals to Unicorn process
Date: Fri, 14 Jul 2017 18:34:11 -0700 [thread overview]
Message-ID: <20170715013411.GE68067@jeremyevans.local> (raw)
In-Reply-To: <20170715001535.GA8205@starla>
On 07/15 12:15, Eric Wong wrote:
> Jeremy Evans <code@jeremyevans.net> wrote:
> > Thanks for this patch. I'm not an RB_GC_GUARD expert, but the changes
> > look fine to me. The existing RB_GC_GUARD calls were added by me in
> > 2012 to fix an earlier segfault.[1] This is the first reported
> > RB_GC_GUARD-related segfault in sequel_pg since then.
>
> No worries; I don't consider myself a RB_GC_GUARD expert, either(*).
>
> > [1] https://github.com/jeremyevans/sequel_pg/commit/15edb132887d9b5292cad419fc7692ed5cd4b01b.diff
>
> I suspect your original guards were lucky enough for C compilers
> in 2012, but compilers have gotten more clever since then. So
> there's a a higher likelyhood of exposing bugs given the
> conservative GC in Ruby(**).
>
> Historical note:
>
> Back in the day, "volatile" alone was enough to defeat
> compiler optimizations in C Ruby. Eventually, compilers got
> better, so RB_GC_GUARD was introduced. And in the future,
> RB_GC_GUARD may evolve to accomodate even more clever
> compilers.
>
> > Pere, I would appreciate if you could test this patch and see if it
> > fixes your issue. I will also test it and will release a new sequel_pg
> > version with this patch if it fixes the issue.
>
> Yes, actually testing the code is important, everything else
> I've written here is theory ;)
All of Sequel's postgres adapter tests still pass with this, so I merged
this into the master branch. I'll do some more testing of my apps, but
unless I run into problems I plan to release this as sequel_pg 1.7.1
early next week.
Thanks,
Jeremy
next prev parent reply other threads:[~2017-07-15 1:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 18:48 Random crash when sending USR2 + QUIT signals to Unicorn process Pere Joan Martorell
2017-07-13 19:34 ` Eric Wong
2017-07-14 10:21 ` Pere Joan Martorell
2017-07-14 21:16 ` Eric Wong
2017-07-14 22:50 ` Jeremy Evans
2017-07-15 0:15 ` Eric Wong
2017-07-15 1:34 ` Jeremy Evans [this message]
2017-07-15 4:45 ` Eric Wong
2017-07-15 7:56 ` Jeremy Evans
2017-07-17 14:32 ` Jeremy Evans
2017-07-24 1:25 ` Eric Wong
2017-08-07 6:16 ` Jeremy Evans
2017-08-07 20:18 ` Eric Wong
2017-10-03 14:52 ` Xuanzhong Wei
2017-10-03 17:15 ` Eric Wong
2017-10-03 18:20 ` Xuanzhong Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715013411.GE68067@jeremyevans.local \
--to=code@jeremyevans.net \
--cc=e@80x24.org \
--cc=maillist@steelskies.com \
--cc=pere.joan@camaloon.com \
--cc=philip@irisconnect.co.uk \
--cc=unicorn-public@bogomips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).