From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id D737E1F576; Sat, 24 Feb 2018 08:08:55 +0000 (UTC) Date: Sat, 24 Feb 2018 08:08:55 +0000 From: Eric Wong To: Fumiaki MATSUSHIMA Cc: unicorn-public@bogomips.org, mtsmfm@gmail.com Subject: Re: [PATCH] Use IO#wait instead to fix test for Ruby 1.9 Message-ID: <20180224080855.GA13738@80x24.org> References: <20180224070636.20651-1-mtsmfm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180224070636.20651-1-mtsmfm@gmail.com> List-Id: Fumiaki MATSUSHIMA wrote: > IO#wait_readable is introduced since 2.0 > > I confirmed we can pass tests for all versions of Ruby with this patch. Thanks, applied. Not sure if it's worth making a new release to fix a test case, so I might wait a bit and see if there's other stuff. Also curious, how long do folks intend to continue using 1.9.3? I don't care for whatever ruby-core claims to support, I know realistically some folks (including distros) continue using older versions for a while and I'll do my best to support them.