unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Dominik George <natureshadow@debian.org>, 918916@bugs.debian.org
Cc: Justin Hallett <thesin@southofheaven.org>, unicorn-public@bogomips.org
Subject: Re: Bug#918916: Unicorn not reporting proper version for gemfile?
Date: Thu, 10 Jan 2019 20:28:21 +0000	[thread overview]
Message-ID: <20190110202821.3gmzl27l4p4n2na3@dcvr> (raw)
In-Reply-To: <20190110200102.GA14520@portux.naturalnet.de>

(unicorn upstream here, adding unicorn-public to Cc,
 for context: <https://bugs.debian.org/918916> )

Dominik George <natureshadow@debian.org> wrote:
> +--- a/unicorn.gemspec
> ++++ b/unicorn.gemspec
> +@@ -11,7 +11,7 @@ end.compact
> + 
> + Gem::Specification.new do |s|
> +   s.name = %q{unicorn}
> +-  s.version = (ENV['VERSION'] || '5.4.1').dup
> ++  s.version = '5.4.1'

Why is ignoring ENV['VERSION'] necessary for the Debian build?
I can probably remove that check if desired from the upstream
package before the 5.5.0 release.

       reply	other threads:[~2019-01-10 20:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E5E85D7F-061C-422C-B02E-8FC248F87986@southofheaven.org>
     [not found] ` <20190110200102.GA14520@portux.naturalnet.de>
2019-01-10 20:28   ` Eric Wong [this message]
2019-01-12  9:42     ` Bug#918916: Unicorn not reporting proper version for gemfile? Hleb Valoshka
2019-01-12 10:04       ` Dominik George
2019-01-12 12:18         ` Hleb Valoshka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110202821.3gmzl27l4p4n2na3@dcvr \
    --to=e@80x24.org \
    --cc=918916@bugs.debian.org \
    --cc=natureshadow@debian.org \
    --cc=thesin@southofheaven.org \
    --cc=unicorn-public@bogomips.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).