From: Jeremy Evans <email@example.com>
To: Eric Wong <firstname.lastname@example.org>
Cc: Stan Pitucha <email@example.com>, firstname.lastname@example.org
Subject: Re: Issues after 5.5.0 upgrade
Date: Tue, 5 Mar 2019 21:57:34 -0800 [thread overview]
Message-ID: <20190306055734.GC61406@jeremyevans.local> (raw)
On 03/06 04:44, Eric Wong wrote:
> Stan Pitucha <email@example.com> wrote:
> > > I only saw one issue (proposed fix below).
> > Sorry, I solved the other one while writing the email but forgot to
> > update the intro.
> > So the fix worked for the issue I mentioned, thanks! Also, running
> > unicorn directly works just fine now.
> You're welcome and thanks for following up!
> > I ran into another regression with unicorn_rails though. We're doing
> > some work in `after_fork` which relies on a class found in
> > `lib/logger_switcher.rb`. Unfortunately it looks like the scope
> > changed and now I get workers respawning in a loop:
> > E, [2019-03-06T15:03:04.990789 #46680] ERROR -- : uninitialized
> > constant #<Class:#<Unicorn::Configurator:0x00007fc3d113d098>>::LoggerSwitcher
> > (NameError)
> Is this with `preload_app true`? I'm not too up-to-date
> with scoping and namespace behavior stuff, actually.
This is just a guess, but we probably want to call the Unicorn.builder
lambda with the same arguments as the rails_builder lambda.
diff --git a/bin/unicorn_rails b/bin/unicorn_rails
index ea4f822..354c1df 100755
@@ -132,11 +132,11 @@ def rails_builder(ru, op, daemonize)
# this lambda won't run until after forking if preload_app is false
# this runs after config file reloading
- lambda do ||
+ lambda do |x, server|
# Rails 3 includes a config.ru, use it if we find it after
# working_directory is bound.
- return Unicorn.builder('config.ru', op).call
+ return Unicorn.builder('config.ru', op).call(x, server)
# Load Rails and (possibly) the private version of Rack it bundles.
If that doesn't fix it, keep reading.
If after_fork is referencing LoggerSwitcher, and preload_app is not set,
then I think the failure should be expected, as in that case after_fork
is called before build_app!. That would not explain a regression,
though, as that behavior should have been true in 5.4.1.
Does the problem go away if you switch after_fork to after_worker_ready?
Is preload_app set to true?
next prev parent reply other threads:[~2019-03-06 5:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 1:47 Issues after 5.5.0 upgrade Stan Pitucha
2019-03-06 2:48 ` Eric Wong
2019-03-06 4:07 ` Stan Pitucha
2019-03-06 4:44 ` Eric Wong
2019-03-06 5:57 ` Jeremy Evans [this message]
2019-03-06 7:27 ` Stan Pitucha
2019-03-07 2:28 ` [PATCH] unicorn_rails: fix regression with Rails >= 3.x in app build Eric Wong
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).