From: Eric Wong <email@example.com>
To: Stephen Demjanenko <firstname.lastname@example.org>
Subject: Re: [PATCH] Rescue failed pipe resizes due to permissions
Date: Fri, 3 May 2019 22:53:56 +0000 [thread overview]
Message-ID: <20190503225356.76cpbof5qvc5djyi@dcvr> (raw)
Thanks, patch looks good; though I'd like to confirm
some things below for the sake of documentation.
> The `EPERM` error gets raised by the Linux kernel if:
> (too_many_pipe_buffers_hard(pipe->user) ||
> too_many_pipe_buffers_soft(pipe->user)) &&
> !capable(CAP_SYS_RESOURCE) && !capable(CAP_SYS_ADMIN)
Which kernel are you running?
Modern kernels prefix that condition with:
if (nr_pages > pipe->buffers &&
Scanning kernel changes with `git log -p -L:pipe_set_size:fs/pipe.c',
I see that check was added in b0b91d18e2e97b741b294af9333824ecc3fadfd8
("pipe: fix limit checking in pipe_set_size()")
which was fixed in Linux v4.9+ and v3.16.57+
> Given that the resize is not strictly necessary Unicorn should
> rescue the error and continue booting.
Agreed. Applied, tested and pushed to master as
Will tag and release v5.5.1 in a day or two.
prev parent reply other threads:[~2019-05-03 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 22:20 [PATCH] Rescue failed pipe resizes due to permissions sdemjanenko
2019-05-03 22:53 ` Eric Wong [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).