unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: unicorn-public@bogomips.org
Subject: [PATCH 3/3] http: memoize more common fields
Date: Thu,  4 Jul 2019 22:01:08 +0000	[thread overview]
Message-ID: <20190704220108.7849-4-e@80x24.org> (raw)
In-Reply-To: <20190704220108.7849-1-e@80x24.org>

"DNT" is common, nowadays.
"Forwarded" is... *shrug* It's an RFC, at least.
"Origin" is a CORS, and something I've seen.

I've seen "Upgrade-Insecure-Requests", "X-Forwarded-Host",
"X-Request-ID", and "X-Requested-With" in the wild, too;
so add those.
---
 ext/unicorn_http/common_fields.gperf | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/ext/unicorn_http/common_fields.gperf b/ext/unicorn_http/common_fields.gperf
index 179afe5..a10f4cd 100644
--- a/ext/unicorn_http/common_fields.gperf
+++ b/ext/unicorn_http/common_fields.gperf
@@ -28,7 +28,11 @@ CONTENT_LENGTH
 CONTENT_TYPE
 COOKIE
 DATE
+# Do Not Track
+DNT
 EXPECT
+# RFC 7239 (does anybody use Forwarded:?)
+FORWARDED
 FROM
 HOST
 IF_MATCH
@@ -39,6 +43,7 @@ IF_UNMODIFIED_SINCE
 # Firefox sends Keep-Alive (or maybe only old versions?)
 KEEP_ALIVE
 MAX_FORWARDS
+ORIGIN
 PRAGMA
 PROXY_AUTHORIZATION
 RANGE
@@ -47,10 +52,15 @@ TE
 TRAILER
 TRANSFER_ENCODING
 UPGRADE
+UPGRADE_INSECURE_REQUESTS
 USER_AGENT
 VIA
 # common proxies set some of these X- headers
 X_FORWARDED_FOR
+X_FORWARDED_HOST
 X_FORWARDED_PROTO
 X_REAL_IP
+X_REQUEST_ID
+# XMLHttpRequest
+X_REQUESTED_WITH
 WARNING
-- 
EW


  parent reply	other threads:[~2019-07-04 22:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 22:01 [PATCH 0/3] http: use gperf for common field memoization Eric Wong
2019-07-04 22:01 ` [PATCH 1/3] unit benchmark for our HTTP parser Eric Wong
2019-07-04 22:01 ` [PATCH 2/3] http: use gperf for common fields optimization Eric Wong
2019-07-04 22:01 ` Eric Wong [this message]
2019-07-05 20:30 ` [PATCH 4/3] http: gperf 3.0.3 compatibility Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704220108.7849-4-e@80x24.org \
    --to=e@80x24.org \
    --cc=unicorn-public@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).