unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Aaron Patterson <aaron.patterson@gmail.com>
Cc: ruby-core@ruby-lang.org, unicorn-public@yhbt.net
Subject: Re: [ruby-core:99185] [Ruby master Bug#17023] How to prevent String memory to be relocated in ruby-ffi
Date: Thu, 16 Jul 2020 00:04:01 +0000	[thread overview]
Message-ID: <20200716000401.GA15291@dcvr> (raw)
In-Reply-To: <647A6735-04C8-4410-A71A-307A2390CFBD@gmail.com>

Aaron Patterson <aaron.patterson@gmail.com> wrote:
> > On Jul 15, 2020, at 4:35 PM, Eric Wong <normalperson@yhbt.net> wrote:
> > Btw, does rb_gc_register_mark_object pin?  A quick glance at
> > gc.c tells me it doesn't, and I'll need to revert commit
> > 2a6cb76d5010cb763ef5a2c305728465d15eb7c9 in unicorn:
> > https://yhbt.net/unicorn-public/20181226050857.6413-1-e@80x24.org/
> 
> Yes, it does pin.  I’m not super proud of this code, but here
> is where objects passed to rb_gc_register_mark_object get
> pinned:
> 
>   https://github.com/ruby/ruby/blob/c2a6295ec04a191c689d22254ac1ad5d665e27ad/vm.c#L2307-L2320

Ah, missed that, thanks.  So all is well in unicorn (for now).

> I don’t know why the mark object array is an array of arrays
> (I assume so as not to waste space in the array buffer?).
> Maybe this could be a more friendly data structure.

It seems so, since rb_ary_push can double the internal buffer.
Anyways, ko1 made commit
a617afc643e17cea5c1960a60adcd5ffb25fdfe2 r46714
Maybe it can be flattened nowadays and rely on GC.compact
to reclaim unused space.

/me goes back to hacking in Perl 5...

      reply	other threads:[~2020-07-16  0:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <redmine.issue-17023.20200710175402.5550@ruby-lang.org>
     [not found] ` <redmine.journal-86563.20200715200039.5550@ruby-lang.org>
2020-07-15 23:35   ` [ruby-core:99184] " Eric Wong
2020-07-15 23:49     ` [ruby-core:99185] " Aaron Patterson
2020-07-16  0:04       ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200716000401.GA15291@dcvr \
    --to=normalperson@yhbt.net \
    --cc=aaron.patterson@gmail.com \
    --cc=ruby-core@ruby-lang.org \
    --cc=unicorn-public@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this inbox:

	../../unicorn.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).