From: Eric Wong <firstname.lastname@example.org> To: Jean Boussier <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] Add early hints support Date: Mon, 20 Jul 2020 20:27:30 +0000 [thread overview] Message-ID: <20200720202730.GA16172@dcvr> (raw) In-Reply-To: <4274A592-FC06-4886-8013-429ABF689695@shopify.com> Jean Boussier <email@example.com> wrote: > > upcase seems VERY compelling in a micro benchmark since it can > > go straight into opt_case_dispatch. But I worry the extra > > garbage might have a different effect in a real app, especially > > with more headers. > > It is indeed debatable. The thing is that on match, that Regexp > will generate a MatchData and a garbage string. So I'd think > the extra GC pressure would be totally negligible. Ah good point. I take it Ruby doesn't lazy-allocate or have optimizations to quickly recycle unused MatchData? (Maybe it could, if somebody who hacks on the VM is reading this). > But I agree it's hard to tell without a larger more representative benchmark. Yes, I would accept patches to speed these up with comprehensive benchmark :) > > Maybe: > > > > (val || ''.freeze).include?("\n".freeze) > > > > Can work for those buggy apps, though... > > Yes. or: > > vall && val.include?... Yes.
prev parent reply other threads:[~2020-07-20 20:27 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-16 10:05 Jean Boussier 2020-07-16 10:50 ` Eric Wong 2020-07-16 11:41 ` Jean Boussier 2020-07-16 12:16 ` Eric Wong 2020-07-16 12:24 ` Jean Boussier 2020-07-17 1:19 ` Eric Wong 2020-07-20 9:18 ` Jean Boussier 2020-07-20 10:09 ` Eric Wong 2020-07-20 10:27 ` Jean Boussier 2020-07-20 10:55 ` Eric Wong 2020-07-20 11:53 ` Jean Boussier 2020-07-20 20:27 ` Eric Wong [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200720202730.GA16172@dcvr \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Add early hints support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: ../../unicorn.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).