unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: unicorn-public@yhbt.net
Cc: Jean Boussier <jean.boussier@gmail.com>
Subject: [PATCH 1/2] test_server: test_early_hints: fix test reliability
Date: Thu, 23 Jul 2020 04:17:34 +0000	[thread overview]
Message-ID: <20200723041735.32361-2-bofh@yhbt.net> (raw)
In-Reply-To: <20200723041735.32361-1-bofh@yhbt.net>

IO#sysread may only capture the 103 response and return before
the server can send the 200.  Since we don't support persistent
connections, we can just use IO#read to rely on the server
giving us an EOF after the 200 is sent.

Cc: Jean Boussier <jean.boussier@gmail.com>
---
 test/unit/test_server.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/unit/test_server.rb b/test/unit/test_server.rb
index d706243..384fa6b 100644
--- a/test/unit/test_server.rb
+++ b/test/unit/test_server.rb
@@ -106,7 +106,7 @@ def test_early_hints
     sock = TCPSocket.new('127.0.0.1', @port)
     sock.syswrite("GET / HTTP/1.0\r\n\r\n")
 
-    responses = sock.sysread(4096)
+    responses = sock.read(4096)
     assert_match %r{\AHTTP/1.[01] 103\b}, responses
     assert_match %r{^Link: </style\.css>}, responses
     assert_match %r{^Link: </script\.js>}, responses

  reply	other threads:[~2020-07-23  4:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  4:17 [PATCH 0/2] some minor early_hints fixes Eric Wong
2020-07-23  4:17 ` Eric Wong [this message]
2020-07-23  4:17 ` [PATCH 2/2] configurator: SIGHUP resets early_hints if unset Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723041735.32361-2-bofh@yhbt.net \
    --to=bofh@yhbt.net \
    --cc=jean.boussier@gmail.com \
    --cc=unicorn-public@yhbt.net \
    --subject='Re: [PATCH 1/2] test_server: test_early_hints: fix test reliability' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	../../unicorn.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).