From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 345C31F5B1; Thu, 23 Jul 2020 04:17:36 +0000 (UTC) From: Eric Wong To: unicorn-public@yhbt.net Cc: Jean Boussier Subject: [PATCH 1/2] test_server: test_early_hints: fix test reliability Date: Thu, 23 Jul 2020 04:17:34 +0000 Message-Id: <20200723041735.32361-2-bofh@yhbt.net> In-Reply-To: <20200723041735.32361-1-bofh@yhbt.net> References: <20200723041735.32361-1-bofh@yhbt.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: IO#sysread may only capture the 103 response and return before the server can send the 200. Since we don't support persistent connections, we can just use IO#read to rely on the server giving us an EOF after the 200 is sent. Cc: Jean Boussier --- test/unit/test_server.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/test_server.rb b/test/unit/test_server.rb index d706243..384fa6b 100644 --- a/test/unit/test_server.rb +++ b/test/unit/test_server.rb @@ -106,7 +106,7 @@ def test_early_hints sock = TCPSocket.new('127.0.0.1', @port) sock.syswrite("GET / HTTP/1.0\r\n\r\n") - responses = sock.sysread(4096) + responses = sock.read(4096) assert_match %r{\AHTTP/1.[01] 103\b}, responses assert_match %r{^Link: }, responses assert_match %r{^Link: }, responses