unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <bofh@yhbt.net>
To: unicorn-public@yhbt.net
Cc: Jean Boussier <jean.boussier@gmail.com>
Subject: [PATCH 2/2] configurator: SIGHUP resets early_hints if unset
Date: Thu, 23 Jul 2020 04:17:35 +0000	[thread overview]
Message-ID: <20200723041735.32361-3-bofh@yhbt.net> (raw)
In-Reply-To: <20200723041735.32361-1-bofh@yhbt.net>

If a user removes "early_hints" entirely from the config file, a
SIGHUP needs to restore the default value.  This is consistent
with the behavior of all the other configuration variables.

Cc: Jean Boussier <jean.boussier@gmail.com>
 lib/unicorn/configurator.rb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/unicorn/configurator.rb b/lib/unicorn/configurator.rb
index b0606af..ecdf03e 100644
--- a/lib/unicorn/configurator.rb
+++ b/lib/unicorn/configurator.rb
@@ -53,6 +53,7 @@ class Unicorn::Configurator
         server.logger.info("worker=#{worker.nr} ready")
     :pid => nil,
+    :early_hints => false,
     :worker_exec => false,
     :preload_app => false,
     :check_client_connection => false,

      parent reply	other threads:[~2020-07-23  4:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  4:17 [PATCH 0/2] some minor early_hints fixes Eric Wong
2020-07-23  4:17 ` [PATCH 1/2] test_server: test_early_hints: fix test reliability Eric Wong
2020-07-23  4:17 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723041735.32361-3-bofh@yhbt.net \
    --to=bofh@yhbt.net \
    --cc=jean.boussier@gmail.com \
    --cc=unicorn-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).