From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E3DBF1F66E; Sun, 6 Sep 2020 09:30:38 +0000 (UTC) Date: Sun, 6 Sep 2020 09:30:38 +0000 From: Eric Wong To: Jean Boussier Cc: unicorn-public@yhbt.net Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 Message-ID: <20200906093038.GA25772@dcvr> References: <03DE8105-749D-46E8-A163-3AAEA72E6087@shopify.com> <20200901144829.GA8068@dcvr> <20200901154117.GA1551@dcvr> <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> <20200903093150.GA21762@dcvr> <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> List-Id: Jean Boussier wrote: > Ok, so the linking issues were simply me being silly. I forgot > to run `make ragel` and commit the output (to use a git gem). > Unicorn now run just fine under 3.0.0-dev (current master). Odd, just "make" (no args) should work. > So here's the patch that warn users about the Ruby version > in extconf.rb and test_helper.rb. > > I'm not too fan of the duplication, but not sure how this could > be shared. The small amount of duplication is fine, thanks. Pushed as commit 06e904f1e8d8e554d8992fbb3de993dff45dec4c I needed to fix column wrapping to be <80 columns to accomodate those needing giant fonts. Anything else in the ruby 3.0 pipeline that might introduce incompatibilities? Not sure if releasing unicorn 5.7 is worth doing soon/now or closer to December 25... Will we even survive until then? This year keeps getting worse :<