unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Jean Boussier <jean.boussier@shopify.com>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0
Date: Tue, 8 Sep 2020 02:24:06 +0000	[thread overview]
Message-ID: <20200908022406.GA32701@dcvr> (raw)
In-Reply-To: <FE6CD4B9-858E-4C10-BF53-262DF66CC488@shopify.com>

Jean Boussier <jean.boussier@shopify.com> wrote:
> >> Ok, so the linking issues were simply me being silly. I forgot
> >> to run `make ragel` and commit the output (to use a git gem).
> >> Unicorn now run just fine under 3.0.0-dev (current master).
> > 
> > Odd, just "make" (no args) should work.
> It does, but the files it generates are in .gitignore, and I was
> trying to use the gem through bundler's git gems. Anyway,
> now I know the drill.

Ah, perhaps adding some checks to extconf.rb would be useful?
Or moving the ragel invocation into the extconf.rb-generated
Makefile? (not too sure how to do that...).

I'm not remotely knowledgeable when it comes to bundler.

> > Anything else in the ruby 3.0 pipeline that might introduce
> > incompatibilities?
> Not that I know of. There not any big breaking change
> planned for 3.0. 

Good to know.

> > Not sure if releasing unicorn 5.7 is worth doing soon/now or
> > closer to December 25...
> It is up to you. But the sooner the better for me. We run
> our master branch CI against ruby master on a nightly
> basis. Until this patch is released I'll have to keep a fork
> around.

OK, soon.  Maybe with just the aforementioned ragel check above;
or not even...  Electric grid is failing and public libraries
are all closed due to COVID-19; so net access can be scarce.

  reply	other threads:[~2020-09-08  2:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 12:17 [PATCH] Update ruby_version requirement to allow ruby 3.0 Jean Boussier
2020-09-01 14:48 ` Eric Wong
2020-09-01 15:04   ` Jean Boussier
2020-09-01 15:41     ` Eric Wong
2020-09-03  7:52       ` Jean Boussier
2020-09-03  8:25         ` Eric Wong
2020-09-03  8:29           ` Jean Boussier
2020-09-03  9:31             ` Eric Wong
2020-09-03 11:23               ` Jean Boussier
2020-09-04 12:34                 ` Jean Boussier
2020-09-06  9:30                   ` Eric Wong
2020-09-07  7:13                     ` Jean Boussier
2020-09-08  2:24                       ` Eric Wong [this message]
2020-09-08  8:00                         ` Jean Boussier
2020-09-08  8:50                           ` Eric Wong
2020-09-08  8:56                             ` Jean Boussier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908022406.GA32701@dcvr \
    --to=e@80x24.org \
    --cc=jean.boussier@shopify.com \
    --cc=unicorn-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).