From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 03EB41F66E; Tue, 8 Sep 2020 02:24:07 +0000 (UTC) Date: Tue, 8 Sep 2020 02:24:06 +0000 From: Eric Wong To: Jean Boussier Cc: unicorn-public@yhbt.net Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 Message-ID: <20200908022406.GA32701@dcvr> References: <20200901154117.GA1551@dcvr> <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> <20200903093150.GA21762@dcvr> <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> <20200906093038.GA25772@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-Id: Jean Boussier wrote: > >> Ok, so the linking issues were simply me being silly. I forgot > >> to run `make ragel` and commit the output (to use a git gem). > >> Unicorn now run just fine under 3.0.0-dev (current master). > > > > Odd, just "make" (no args) should work. > > It does, but the files it generates are in .gitignore, and I was > trying to use the gem through bundler's git gems. Anyway, > now I know the drill. Ah, perhaps adding some checks to extconf.rb would be useful? Or moving the ragel invocation into the extconf.rb-generated Makefile? (not too sure how to do that...). I'm not remotely knowledgeable when it comes to bundler. > > Anything else in the ruby 3.0 pipeline that might introduce > > incompatibilities? > > Not that I know of. There not any big breaking change > planned for 3.0. Good to know. > > Not sure if releasing unicorn 5.7 is worth doing soon/now or > > closer to December 25... > > It is up to you. But the sooner the better for me. We run > our master branch CI against ruby master on a nightly > basis. Until this patch is released I'll have to keep a fork > around. OK, soon. Maybe with just the aforementioned ragel check above; or not even... Electric grid is failing and public libraries are all closed due to COVID-19; so net access can be scarce.