From: Eric Wong <e@80x24.org>
To: Jean Boussier <jean.boussier@shopify.com>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0
Date: Tue, 8 Sep 2020 08:50:43 +0000 [thread overview]
Message-ID: <20200908085043.GA7160@dcvr> (raw)
In-Reply-To: <68EFB742-652D-427D-8853-E377336034D5@shopify.com>
Jean Boussier <jean.boussier@shopify.com> wrote:
> > Ah, perhaps adding some checks to extconf.rb would be useful?
> > Or moving the ragel invocation into the extconf.rb-generated
> > Makefile? (not too sure how to do that...).
>
> Not really no. And it would make ragel a build dependency.
No, the generated .c file would still be distributed with the
gem as it is today. I'm absolutely against introducing new
build requirements (optional dependencies, maybe, but not
requirements).
Changing the .rl file might result in ragel running (or emit
warning if ragel isn't installed). Not too sure how to do that
via mkmf, though... Or it would just throw a warning and drop a
hint to run "make ragel" at the top-level if the .c file is
missing...
> But really I don't think so many people need to use unicorn
> branches.
*shrug* I figure for any one person that posts a comment for
something on any public forum, there's probably 10 that feel the
same way.
> > OK, soon. Maybe with just the aforementioned ragel check above;
> > or not even...
>
> I'd say not even. It's just for people like me trying to run branches.
Alright, we can experiment with more build system changes
another time another (and I zoned out while writing the 5.7
release notes and forgot to note the minor build system changes
I made right after th 5.6.0 release :x)
https://yhbt.net/unicorn-public/20200908084429.GA16521@dcvr/
next prev parent reply other threads:[~2020-09-08 8:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 12:17 [PATCH] Update ruby_version requirement to allow ruby 3.0 Jean Boussier
2020-09-01 14:48 ` Eric Wong
2020-09-01 15:04 ` Jean Boussier
2020-09-01 15:41 ` Eric Wong
2020-09-03 7:52 ` Jean Boussier
2020-09-03 8:25 ` Eric Wong
2020-09-03 8:29 ` Jean Boussier
2020-09-03 9:31 ` Eric Wong
2020-09-03 11:23 ` Jean Boussier
2020-09-04 12:34 ` Jean Boussier
2020-09-06 9:30 ` Eric Wong
2020-09-07 7:13 ` Jean Boussier
2020-09-08 2:24 ` Eric Wong
2020-09-08 8:00 ` Jean Boussier
2020-09-08 8:50 ` Eric Wong [this message]
2020-09-08 8:56 ` Jean Boussier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908085043.GA7160@dcvr \
--to=e@80x24.org \
--cc=jean.boussier@shopify.com \
--cc=unicorn-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).