From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2CD401F4B4; Tue, 8 Sep 2020 08:50:43 +0000 (UTC) Date: Tue, 8 Sep 2020 08:50:43 +0000 From: Eric Wong To: Jean Boussier Cc: unicorn-public@yhbt.net Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 Message-ID: <20200908085043.GA7160@dcvr> References: <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> <20200903093150.GA21762@dcvr> <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> <20200906093038.GA25772@dcvr> <20200908022406.GA32701@dcvr> <68EFB742-652D-427D-8853-E377336034D5@shopify.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <68EFB742-652D-427D-8853-E377336034D5@shopify.com> List-Id: Jean Boussier wrote: > > Ah, perhaps adding some checks to extconf.rb would be useful? > > Or moving the ragel invocation into the extconf.rb-generated > > Makefile? (not too sure how to do that...). > > Not really no. And it would make ragel a build dependency. No, the generated .c file would still be distributed with the gem as it is today. I'm absolutely against introducing new build requirements (optional dependencies, maybe, but not requirements). Changing the .rl file might result in ragel running (or emit warning if ragel isn't installed). Not too sure how to do that via mkmf, though... Or it would just throw a warning and drop a hint to run "make ragel" at the top-level if the .c file is missing... > But really I don't think so many people need to use unicorn > branches. *shrug* I figure for any one person that posts a comment for something on any public forum, there's probably 10 that feel the same way. > > OK, soon. Maybe with just the aforementioned ragel check above; > > or not even... > > I'd say not even. It's just for people like me trying to run branches. Alright, we can experiment with more build system changes another time another (and I zoned out while writing the 5.7 release notes and forgot to note the minor build system changes I made right after th 5.6.0 release :x) https://yhbt.net/unicorn-public/20200908084429.GA16521@dcvr/