From: Eric Wong <firstname.lastname@example.org> To: Blake Williams <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] Add rack.after_reply functionality Date: Wed, 9 Dec 2020 09:43:44 +0000 Message-ID: <20201209094344.GA25593@dcvr> (raw) In-Reply-To: <E04F9E8A-02F6-42BC-831C-7AFF2B2F3615@blakewilliams.me> Blake Williams <email@example.com> wrote: > > > In the past, I've used response_body.close in middleware for > > similar things, and nowadays Rack::BodyProxy exists in rack, too. > > > > So I'm a little skeptical if this is actually needed, but it's > > probably too late to do anything about: > > The first approach we took uses Rack::Events, which I believe is using > Rack::BodyProxy under the hood. We ran into an issue where all but > the last line of the response is written and the connection isn’t > actually closed yet when the callbacks are called. OK. Keep in mind this can be server-dependent since unicorn can't support persistent connections while (most?) other servers do (and they may disable TCP_CORK or Nagle, etc). > > Citation(s) needed. Also, are there any proposal(s) to get this > > into the Rack specification? > > Not that I’m aware of. But I agree that it and early_hints could both be > good additions to the spec. By "Citation(s) needed", can you list some other (preferably well-known) Rack servers which also implement this feature? We wouldn't want current unicorn users thinking we're adopting random new things which nobody else supports :> Thanks.
next prev parent reply other threads:[~2020-12-09 9:43 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-08 21:47 Blake Williams 2020-12-08 22:46 ` Eric Wong 2020-12-08 23:48 ` Blake Williams 2020-12-09 9:43 ` Eric Wong [this message] 2020-12-09 14:58 ` Blake Williams 2020-12-09 22:18 ` Eric Wong 2020-12-09 23:44 ` Blake Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201209094344.GA25593@dcvr \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help This inbox may be cloned and mirrored by anyone: git clone --mirror https://yhbt.net/unicorn-public git clone --mirror http://ou63pmih66umazou.onion/unicorn-public # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 unicorn-public unicorn-public/ https://yhbt.net/unicorn-public \ email@example.com firstname.lastname@example.org email@example.com mongrel-unicorn-GrnCvJ7WPxnNLxjTenLetw@public.gmane.org public-inbox-index unicorn-public Example config snippet for mirrors. Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.lang.ruby.unicorn nntp://ou63pmih66umazou.onion/inbox.comp.lang.ruby.unicorn note: .onion URLs require Tor: https://www.torproject.org/ code repositories for the project(s) associated with this inbox: ../../unicorn.git AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git