unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: Blake Williams <blake@blakewilliams.me>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Add rack.after_reply functionality
Date: Wed, 9 Dec 2020 09:43:44 +0000	[thread overview]
Message-ID: <20201209094344.GA25593@dcvr> (raw)
In-Reply-To: <E04F9E8A-02F6-42BC-831C-7AFF2B2F3615@blakewilliams.me>

Blake Williams <blake@blakewilliams.me> wrote:
> > In the past, I've used response_body.close in middleware for
> > similar things, and nowadays Rack::BodyProxy exists in rack, too.
> > 
> > So I'm a little skeptical if this is actually needed, but it's
> > probably too late to do anything about:
> The first approach we took uses Rack::Events, which I believe is using
> Rack::BodyProxy under the hood. We ran into an issue where all but
> the last line of the response is written and the connection isn’t
> actually closed yet when the callbacks are called.

OK.  Keep in mind this can be server-dependent since unicorn
can't support persistent connections while (most?) other servers
do (and they may disable TCP_CORK or Nagle, etc).

> > Citation(s) needed.  Also, are there any proposal(s) to get this
> > into the Rack specification?
> Not that I’m aware of. But I agree that it and early_hints could both be
> good additions to the spec.

By "Citation(s) needed", can you list some other (preferably
well-known) Rack servers which also implement this feature?

We wouldn't want current unicorn users thinking we're adopting
random new things which nobody else supports :>


  reply	other threads:[~2020-12-09  9:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 21:47 [PATCH] Add rack.after_reply functionality Blake Williams
2020-12-08 22:46 ` Eric Wong
2020-12-08 23:48   ` Blake Williams
2020-12-09  9:43     ` Eric Wong [this message]
2020-12-09 14:58       ` Blake Williams
2020-12-09 22:18         ` Eric Wong
2020-12-09 23:44           ` Blake Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209094344.GA25593@dcvr \
    --to=e@80x24.org \
    --cc=blake@blakewilliams.me \
    --cc=unicorn-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).