From: Eric Wong <bofh@yhbt.net> To: unicorn-public@yhbt.net Subject: [PATCH 4/6] http_server: get rid of Process.ppid check Date: Fri, 1 Oct 2021 03:09:21 +0000 [thread overview] Message-ID: <20211001030923.26705-5-bofh@yhbt.net> (raw) In-Reply-To: <20211001030923.26705-1-bofh@yhbt.net> It's actually been unnecessary since commit 6f6e4115b4bb03e5 (rework master-to-worker signaling to use a pipe, 2013-12-09) --- lib/unicorn/http_server.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/unicorn/http_server.rb b/lib/unicorn/http_server.rb index cd6e63b..09c5ec2 100644 --- a/lib/unicorn/http_server.rb +++ b/lib/unicorn/http_server.rb @@ -708,7 +708,6 @@ def reopen_worker_logs(worker_nr) # for connections and doesn't die until the parent dies (or is # given a INT, QUIT, or TERM signal) def worker_loop(worker) - ppid = @master_pid readers = init_worker_process(worker) nr = 0 # this becomes negative if we need to reopen logs @@ -745,8 +744,6 @@ def worker_loop(worker) redo end - ppid == Process.ppid or return - # timeout used so we can detect parent death: worker.tick = time_now.to_i ret = IO.select(readers, nil, nil, @timeout) and ready = ret[0]
next prev parent reply other threads:[~2021-10-01 3:09 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-01 3:09 [PATCH 0/6] reduce thundering herds on Linux 4.5+ Eric Wong 2021-10-01 3:09 ` [PATCH 1/6] extconf.rb: get rid of unnecessary checks Eric Wong 2021-10-01 3:09 ` [PATCH 2/6] makefile: reduce unnecessary rebuilds Eric Wong 2021-10-01 3:09 ` [PATCH 3/6] HACKING: drop outdated information about pandoc Eric Wong 2021-10-01 3:09 ` Eric Wong [this message] 2021-10-01 3:09 ` [PATCH 5/6] worker_loop: get rid of select() avoidance hack Eric Wong 2021-10-01 3:09 ` [PATCH 6/6] use EPOLLEXCLUSIVE on Linux 4.5+ Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211001030923.26705-5-bofh@yhbt.net \ --to=bofh@yhbt.net \ --cc=unicorn-public@yhbt.net \ --subject='Re: [PATCH 4/6] http_server: get rid of Process.ppid check' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: ../../unicorn.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).