From: Jean Boussier <firstname.lastname@example.org> To: Eric Wong <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] Add early hints support Date: Mon, 20 Jul 2020 11:18:53 +0200 [thread overview] Message-ID: <624157B8-884C-42EB-8515-AFC6807D6F8D@shopify.com> (raw) In-Reply-To: <20200717011955.GA23522@dcvr> > I guess... I was wondering more in terms of the big picture with > HTTP parsing, I/O, and response generation taken into account. I wasn't too sure how to benchmark the entire loop. But regardless 18/20M i/s shows that it should be meaningless. It's only executed once per request, so would "waste" 1 second for 18 million requests processed. > (and there may be improvements in those areas later this year, > assuming the world doesn't end sooner...) If you are interested in general optimizations, I did spot a bunch of sub optimal patterns, such as `=~` in places where a string comparison, or `match?` would do. However many optimizations are only available on more recent rubies.
next prev parent reply other threads:[~2020-07-20 9:18 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-16 10:05 Jean Boussier 2020-07-16 10:50 ` Eric Wong 2020-07-16 11:41 ` Jean Boussier 2020-07-16 12:16 ` Eric Wong 2020-07-16 12:24 ` Jean Boussier 2020-07-17 1:19 ` Eric Wong 2020-07-20 9:18 ` Jean Boussier [this message] 2020-07-20 10:09 ` Eric Wong 2020-07-20 10:27 ` Jean Boussier 2020-07-20 10:55 ` Eric Wong 2020-07-20 11:53 ` Jean Boussier 2020-07-20 20:27 ` Eric Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://yhbt.net/unicorn/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=624157B8-884C-42EB-8515-AFC6807D6F8D@shopify.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] Add early hints support' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: ../../unicorn.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).