unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Jean Boussier <jean.boussier@shopify.com>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0
Date: Tue, 8 Sep 2020 10:00:23 +0200	[thread overview]
Message-ID: <68EFB742-652D-427D-8853-E377336034D5@shopify.com> (raw)
In-Reply-To: <20200908022406.GA32701@dcvr>

> Ah, perhaps adding some checks to extconf.rb would be useful?
> Or moving the ragel invocation into the extconf.rb-generated
> Makefile? (not too sure how to do that...).

Not really no. And it would make ragel a build dependency.

> I'm not remotely knowledgeable when it comes to bundler.

That's fine, it just makes unicorn a bit harder to use outside of
rubygems releases. But long story short bundler git gems is
pretty much:

  - git clone repo
  - gem build repo.gemspec
  - gem install repo-...

So nothing is executed besides the extconf.rb. Which mean
the version file and the generated.c file would need to be
committed in the repository rather than in .gitignore.

But really I don't think so many people need to use unicorn

> OK, soon.  Maybe with just the aforementioned ragel check above;
> or not even...  

I'd say not even. It's just for people like me trying to run branches.

  reply	other threads:[~2020-09-08  8:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 12:17 [PATCH] Update ruby_version requirement to allow ruby 3.0 Jean Boussier
2020-09-01 14:48 ` Eric Wong
2020-09-01 15:04   ` Jean Boussier
2020-09-01 15:41     ` Eric Wong
2020-09-03  7:52       ` Jean Boussier
2020-09-03  8:25         ` Eric Wong
2020-09-03  8:29           ` Jean Boussier
2020-09-03  9:31             ` Eric Wong
2020-09-03 11:23               ` Jean Boussier
2020-09-04 12:34                 ` Jean Boussier
2020-09-06  9:30                   ` Eric Wong
2020-09-07  7:13                     ` Jean Boussier
2020-09-08  2:24                       ` Eric Wong
2020-09-08  8:00                         ` Jean Boussier [this message]
2020-09-08  8:50                           ` Eric Wong
2020-09-08  8:56                             ` Jean Boussier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68EFB742-652D-427D-8853-E377336034D5@shopify.com \
    --to=jean.boussier@shopify.com \
    --cc=e@80x24.org \
    --cc=unicorn-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).