From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 756491F66E for ; Tue, 8 Sep 2020 08:00:26 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id a17so18022902wrn.6 for ; Tue, 08 Sep 2020 01:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UHXoO4+zk2tLVJFg7eipjUsZe+oM4PFv2NPpaJJO/Zc=; b=cyWHanq49mINoxY200BYUlI96LeOYH0/rnUgkR0z8jeRCgotUZLaa50MjQkVyAJ36g ocHULnccwg4QNDs892M+gchANJTRBhcN2wCMGJnwYfEAczKlBp5F/aQSuwdYHmVYhuI9 7+5CdtZWadiFzaUw3tWGTViRX+gic5kzVSX8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=UHXoO4+zk2tLVJFg7eipjUsZe+oM4PFv2NPpaJJO/Zc=; b=YVpiFgR/3QLrBM+mWFYHNHIBZm7+UQ8yr+WqcTrYT64jEyuNdvMvKtll3WdQuADd82 zloOouGqdqRA2sgsYN3wnH0tDygDVHJgXKVLzD46u63Hub04gPgy2IYPGvVm97BppxFU PwyYHLHaPXZHHRlJ+FCW3nVCBx4ZVf4OJI7ms8bDcSKYaEMFWjRHPHpzqKgUuTPTweoW yKQy4/6woLTEGmDFvGtrlMdWerM/xq1xAFmb5pgmzS89YxWCmFqJtrmXcftsw23bFoPq Rrcn6nrCZmIXRkpnLzldIKvHZllHwffEvzncO7rcPxOy+UvpCf6jaMLmbRWJ1qztS7aC lgng== X-Gm-Message-State: AOAM530tdwtAqHN2UAGpBaHVda+3kv/Db/dVrU73Q84G4cvNtFirAq4c q6it/PQIXsbkpiM3YZ25dqnaAw== X-Google-Smtp-Source: ABdhPJxZsfoURsd0TGWk7zHaBobCl9FECC4GJucp6KmOEFC4fkl7aHKR47c8teDgEXFxM1bwsG3uzw== X-Received: by 2002:a5d:6283:: with SMTP id k3mr26446336wru.191.1599552024519; Tue, 08 Sep 2020 01:00:24 -0700 (PDT) Received: from [192.168.0.19] (87-231-62-161.rev.numericable.fr. [87.231.62.161]) by smtp.gmail.com with ESMTPSA id f23sm37791364wmc.3.2020.09.08.01.00.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Sep 2020 01:00:24 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 From: Jean Boussier In-Reply-To: <20200908022406.GA32701@dcvr> Date: Tue, 8 Sep 2020 10:00:23 +0200 Cc: unicorn-public@yhbt.net Content-Transfer-Encoding: 7bit Message-Id: <68EFB742-652D-427D-8853-E377336034D5@shopify.com> References: <20200901154117.GA1551@dcvr> <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> <20200903093150.GA21762@dcvr> <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> <20200906093038.GA25772@dcvr> <20200908022406.GA32701@dcvr> To: Eric Wong X-Mailer: Apple Mail (2.3608.120.23.2.1) List-Id: > Ah, perhaps adding some checks to extconf.rb would be useful? > Or moving the ragel invocation into the extconf.rb-generated > Makefile? (not too sure how to do that...). Not really no. And it would make ragel a build dependency. > I'm not remotely knowledgeable when it comes to bundler. That's fine, it just makes unicorn a bit harder to use outside of rubygems releases. But long story short bundler git gems is pretty much: - git clone repo - gem build repo.gemspec - gem install repo-... So nothing is executed besides the extconf.rb. Which mean the version file and the generated.c file would need to be committed in the repository rather than in .gitignore. But really I don't think so many people need to use unicorn branches. > OK, soon. Maybe with just the aforementioned ragel check above; > or not even... I'd say not even. It's just for people like me trying to run branches.