unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Jean Boussier <jean.boussier@shopify.com>
To: Eric Wong <e@80x24.org>
Cc: unicorn-public@yhbt.net
Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0
Date: Tue, 8 Sep 2020 10:56:23 +0200	[thread overview]
Message-ID: <8194A50A-5107-4632-A6FB-2E9F53C2D5F0@shopify.com> (raw)
In-Reply-To: <20200908085043.GA7160@dcvr>

>>> Ah, perhaps adding some checks to extconf.rb would be useful?
>>> Or moving the ragel invocation into the extconf.rb-generated
>>> Makefile? (not too sure how to do that...).
>> Not really no. And it would make ragel a build dependency.
> No, the generated .c file would still be distributed with the
> gem as it is today.

I meant if the gem is used as a "git gem" through bundler.
That's why some other gems like puma commit the generated
.c files.

> Changing the .rl file might result in ragel running (or emit
> warning if ragel isn't installed).  Not too sure how to do that
> via mkmf, though...  Or it would just throw a warning and drop a
> hint to run "make ragel" at the top-level if the .c file is
> missing...

The thing is ragel isn't part of packages such as build-essentials
etc. So really it wouldn't help much.

It just took me a while to figure out because I was tired, but in
the end it wasn't that bad: 

      reply	other threads:[~2020-09-08  8:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01 12:17 [PATCH] Update ruby_version requirement to allow ruby 3.0 Jean Boussier
2020-09-01 14:48 ` Eric Wong
2020-09-01 15:04   ` Jean Boussier
2020-09-01 15:41     ` Eric Wong
2020-09-03  7:52       ` Jean Boussier
2020-09-03  8:25         ` Eric Wong
2020-09-03  8:29           ` Jean Boussier
2020-09-03  9:31             ` Eric Wong
2020-09-03 11:23               ` Jean Boussier
2020-09-04 12:34                 ` Jean Boussier
2020-09-06  9:30                   ` Eric Wong
2020-09-07  7:13                     ` Jean Boussier
2020-09-08  2:24                       ` Eric Wong
2020-09-08  8:00                         ` Jean Boussier
2020-09-08  8:50                           ` Eric Wong
2020-09-08  8:56                             ` Jean Boussier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8194A50A-5107-4632-A6FB-2E9F53C2D5F0@shopify.com \
    --to=jean.boussier@shopify.com \
    --cc=e@80x24.org \
    --cc=unicorn-public@yhbt.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).