From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 05ED31F4B4 for ; Tue, 8 Sep 2020 08:56:26 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id z9so16339010wmk.1 for ; Tue, 08 Sep 2020 01:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=I4FdoJqZvVIM7vmuOG/ixn0bat7SywtrHDNIuOv3OVQ=; b=I7T11H35aQNM8gHFE6zCe2CGQ4gO2Qfol8oqtC+eDb+dGwi5BALuTrNX134FFb+tsC JZEwSA0w9w8ZP5G5tdyv3eZHw5eHB6MP+OH5f2emtztInKksWH8VVnJZB1zvp8j4lhjh 3Y/+t+3tVulzNP51uDPNHnDhxoXaH47ccUKu8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=I4FdoJqZvVIM7vmuOG/ixn0bat7SywtrHDNIuOv3OVQ=; b=SBUhjfrvaLYQnDqKQyk+b9wqZuaPfFblrf/qv1HERJknspQnIpe9fktUiMWAXv9fUU Kk3V7INZ9NF67CaSmbv6QVjfhSWEq0ZuS9S8+mO7AeCQIO1ChGEyGWMGwqGqE0Z01P48 3QwIPPxEEop44uvkKf0bzAUeUWuZ5u4McLjiBUdDGFbzsq2lt/9nQeG+whXuIBQDFUoJ h6muJsk5vqm2Ad64TGadoCKhkke04zfusJvE+uXtIx75kJcdRDL3E7BfN6XjR0+P3ESb KV0wL6Twh3PRKo7LpurHhJgJyGSGg75kZ5nnE5k+hJoq7FzNRyOjawyzik1ivDTeVoaX vLGg== X-Gm-Message-State: AOAM533uDNE6lhA6brlEITI1gF7IYzLY0C34/lXOcY2rv0GDNc/PqjcI tZSvNtZ1IPHAQYQLmPMjGHnR7ER8qHREXg== X-Google-Smtp-Source: ABdhPJxB5/8eqcKhZYVdo1aBKkbq2Zhz1Rvl/ECOkXqNpJ4J5fGMwzMLeQUGz7Kt0fZ8S7y5miRisQ== X-Received: by 2002:a05:600c:22d1:: with SMTP id 17mr3265627wmg.58.1599555384439; Tue, 08 Sep 2020 01:56:24 -0700 (PDT) Received: from [192.168.0.19] (87-231-62-161.rev.numericable.fr. [87.231.62.161]) by smtp.gmail.com with ESMTPSA id d25sm8284258wra.25.2020.09.08.01.56.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Sep 2020 01:56:23 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 From: Jean Boussier In-Reply-To: <20200908085043.GA7160@dcvr> Date: Tue, 8 Sep 2020 10:56:23 +0200 Cc: unicorn-public@yhbt.net Content-Transfer-Encoding: 7bit Message-Id: <8194A50A-5107-4632-A6FB-2E9F53C2D5F0@shopify.com> References: <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> <20200903093150.GA21762@dcvr> <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> <20200906093038.GA25772@dcvr> <20200908022406.GA32701@dcvr> <68EFB742-652D-427D-8853-E377336034D5@shopify.com> <20200908085043.GA7160@dcvr> To: Eric Wong X-Mailer: Apple Mail (2.3608.120.23.2.1) List-Id: >>> Ah, perhaps adding some checks to extconf.rb would be useful? >>> Or moving the ragel invocation into the extconf.rb-generated >>> Makefile? (not too sure how to do that...). >> >> Not really no. And it would make ragel a build dependency. > > No, the generated .c file would still be distributed with the > gem as it is today. I meant if the gem is used as a "git gem" through bundler. That's why some other gems like puma commit the generated .c files. > Changing the .rl file might result in ragel running (or emit > warning if ragel isn't installed). Not too sure how to do that > via mkmf, though... Or it would just throw a warning and drop a > hint to run "make ragel" at the top-level if the .c file is > missing... The thing is ragel isn't part of packages such as build-essentials etc. So really it wouldn't help much. It just took me a while to figure out because I was tired, but in the end it wasn't that bad: https://github.com/Shopify/unicorn/compare/upstream-master...Shopify:ruby-3.0