unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
* [ANN] unicorn 0.93.2 - more compatible with Rails
@ 2009-10-07  8:58 Eric Wong
  2009-10-07 18:04 ` Chris Wanstrath
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2009-10-07  8:58 UTC (permalink / raw)
  To: mongrel-unicorn

Unicorn is a HTTP server for Rack applications designed to take
advantage of features in Unix/Unix-like kernels and only serve fast
clients on low-latency, high-bandwidth connections.  Slow clients should
only be served by placing a reverse proxy capable of fully-buffering
both the the request and response in between Unicorn and slow clients.

* http://unicorn.bogomips.org/
* mongrel-unicorn@rubyforge.org
* git://git.bogomips.org/unicorn.git

Thanks to Chris Wanstrath for reporting issues with large
POST bodies and for helping me test.

Changes:

Avoid truncated POST bodies with URL-encoded forms in Rails
by switching TeeInput to use read-in-full semantics (only) when
a Content-Length: header exists.  Chunked request bodies
continue to exhibit readpartial semantics to support
simultaneous bidirectional chunking.

The lack of return value checking in Rails to protect against a
short ios.read(length) is entirely reasonable even if not
pedantically correct.  Most ios.read(length) implementations
return the full amount requested except right before EOF.

A ticket has been opened here to track the issue:
  https://rails.lighthouseapp.com/projects/8994/tickets/3343

Also there are some minor documentation improvements.

Eric Wong (8):
      Fix NEWS generation on single-paragraph tag messages
      Include GPLv2 in docs
      doc: make it clear contributors retain copyrights
      TODO: removed Rainbows! (see rainbows.rubyforge.org)
      Document the START_CTX hash contents
      more-compatible TeeInput#read for POSTs with Content-Length
      tests for read-in-full vs readpartial semantics
      unicorn 0.93.2
-- 
Eric Wong

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ANN] unicorn 0.93.2 - more compatible with Rails
  2009-10-07  8:58 [ANN] unicorn 0.93.2 - more compatible with Rails Eric Wong
@ 2009-10-07 18:04 ` Chris Wanstrath
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Wanstrath @ 2009-10-07 18:04 UTC (permalink / raw)
  To: Eric Wong; +Cc: mongrel-unicorn

On Wed, Oct 7, 2009 at 1:58 AM, Eric Wong <normalperson@yhbt.net> wrote:

> Changes:
>
> Avoid truncated POST bodies with URL-encoded forms in Rails
> by switching TeeInput to use read-in-full semantics (only) when
> a Content-Length: header exists.  Chunked request bodies
> continue to exhibit readpartial semantics to support
> simultaneous bidirectional chunking.
>
> The lack of return value checking in Rails to protect against a
> short ios.read(length) is entirely reasonable even if not
> pedantically correct.  Most ios.read(length) implementations
> return the full amount requested except right before EOF.
>
> A ticket has been opened here to track the issue:
>  https://rails.lighthouseapp.com/projects/8994/tickets/3343

This release fixes the POST issue we saw. Thanks!

-- 
Chris Wanstrath
http://github.com/defunkt

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-07 18:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-07  8:58 [ANN] unicorn 0.93.2 - more compatible with Rails Eric Wong
2009-10-07 18:04 ` Chris Wanstrath

Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).