From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 017DD1F66E for ; Fri, 4 Sep 2020 12:34:41 +0000 (UTC) Received: by mail-wr1-x42a.google.com with SMTP id w5so6584886wrp.8 for ; Fri, 04 Sep 2020 05:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopify.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gpTXwvV8f5lWm9w9E63+3GT4V04K6wG/ef9VSAAJluc=; b=QXw2yzI0sgDy+PVRxTwVMKbOZbxCkW7GimAT22tItG2TUu4/QPO5kJNCYpfwwbWhr5 TNHaO6gjroxHKZJsVcOH0IwGvZLjHVW+6d7JievRoBA8RtJF8kfY4Eu9rYLRJ+QAXFff U7/EgbDyQMvkK6xNs2Z6tap5/yTDS+DwVlZa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=gpTXwvV8f5lWm9w9E63+3GT4V04K6wG/ef9VSAAJluc=; b=Xr7sir/hrOJTBNrklRAf7tH+7YbXvVosfavGW9NUllLqPZgc+h4EFgfws4eetA/Fm9 HcjRLWVZSGjUyKn4/boM72mkPeKgsDvn9dglJrWseVM7dARoWQbcGbJwoEyewxd3F6uo ZevELcCNjXYQxZRNDTm9SU20OWABFy4OTWqZt4JfHokfSx+e6UW7x3FChfPmA+FmuSw9 R9SZMJeTDTTQqbzl27nCyPD9UMpLUPp+2jLuuRMVTKF18EErNkfZ1rsXqyipz4jEPLcs osqaL5z9totTBOHuywSzT3Cn2WxeCjmMFbB+Xaik2VDydLyUsa2YMvBfRmU17YXQgEIK jnUQ== X-Gm-Message-State: AOAM530uKG/1eG6oDmuJzqX3cZixpY0Bu5hXXsCsA23QTX4RrR/1AC9h Er2BMJ49LINY3X2KATJyOvoOcQ== X-Google-Smtp-Source: ABdhPJw/RFi8KHXYGKYnzLOeptSU76oo/m1GB9RM+sPFnJNphmHJ9OwhE1inhSV88PzjEXbfMmI5BQ== X-Received: by 2002:a5d:5090:: with SMTP id a16mr7936086wrt.247.1599222878668; Fri, 04 Sep 2020 05:34:38 -0700 (PDT) Received: from [192.168.0.19] (87-231-62-161.rev.numericable.fr. [87.231.62.161]) by smtp.gmail.com with ESMTPSA id z11sm10921706wru.88.2020.09.04.05.34.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Sep 2020 05:34:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Subject: Re: [PATCH] Update ruby_version requirement to allow ruby 3.0 From: Jean Boussier In-Reply-To: <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> Date: Fri, 4 Sep 2020 14:34:37 +0200 Cc: unicorn-public@yhbt.net Content-Transfer-Encoding: quoted-printable Message-Id: <90FCA912-2FEF-4D7C-8DEA-0F3D25E1CBBC@shopify.com> References: <03DE8105-749D-46E8-A163-3AAEA72E6087@shopify.com> <20200901144829.GA8068@dcvr> <20200901154117.GA1551@dcvr> <1301173B-0CA2-4498-9A9A-A042FEF9665A@shopify.com> <20200903082513.GA21482@dcvr> <20200903093150.GA21762@dcvr> <389E28C3-EF27-4E2D-94D0-0C8E95AA4488@shopify.com> To: Eric Wong X-Mailer: Apple Mail (2.3608.120.23.2.1) List-Id: Ok, so the linking issues were simply me being silly. I forgot to run `make ragel` and commit the output (to use a git gem). Unicorn now run just fine under 3.0.0-dev (current master). So here's the patch that warn users about the Ruby version in extconf.rb and test_helper.rb. I'm not too fan of the duplication, but not sure how this could be shared. --=20 =46rom 68a862f65d6bc202bc4191a495e87626c2e4bfa3 Mon Sep 17 00:00:00 2001 From: Jean Boussier Date: Tue, 1 Sep 2020 17:00:12 +0200 Subject: [PATCH] Update ruby_version requirement to allow ruby 3.0 Ruby just recently bump the master version to 3.0. This requirement bump is necessary to test unicorn against ruby master. --- ext/unicorn_http/extconf.rb | 4 ++++ test/test_helper.rb | 4 ++++ unicorn.gemspec | 9 +++++---- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/ext/unicorn_http/extconf.rb b/ext/unicorn_http/extconf.rb index d5f81fb..2e9a7f1 100644 --- a/ext/unicorn_http/extconf.rb +++ b/ext/unicorn_http/extconf.rb @@ -1,6 +1,10 @@ # -*- encoding: binary -*- require 'mkmf' =20 +unless RUBY_VERSION < '3.1' + warn "Unicorn was only tested against MRI up to 3.0. It might not = properly work with #{RUBY_VERSION}" +end + have_macro("SIZEOF_OFF_T", "ruby.h") or check_sizeof("off_t", = "sys/types.h") have_macro("SIZEOF_SIZE_T", "ruby.h") or check_sizeof("size_t", = "sys/types.h") have_macro("SIZEOF_LONG", "ruby.h") or check_sizeof("long", = "sys/types.h") diff --git a/test/test_helper.rb b/test/test_helper.rb index e3c6ad4..19528f4 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -34,6 +34,10 @@ Debugger.start end =20 +unless RUBY_VERSION < '3.1' + warn "Unicorn was only tested against MRI up to 3.0. It might not = properly work with #{RUBY_VERSION}" +end + def redirect_test_io orig_err =3D STDERR.dup orig_out =3D STDOUT.dup diff --git a/unicorn.gemspec b/unicorn.gemspec index cbe855d..e6af44d 100644 --- a/unicorn.gemspec +++ b/unicorn.gemspec @@ -25,10 +25,11 @@ s.homepage =3D 'https://yhbt.net/unicorn/' s.test_files =3D test_files =20 - # technically we need ">=3D 1.9.3", too, but avoid the array here = since - # old rubygems versions (1.8.23.2 at least) do not support multiple - # version requirements here. - s.required_ruby_version =3D '< 3.0' + # 1.9.3 is the minumum supported version. We don't specify + # a maximum version to make it easier to test pre-releases, + # but we do warn users if they install unicorn on an untested + # version in extconf.rb + s.required_ruby_version =3D ">=3D 1.9.3" =20 # We do not have a hard dependency on rack, it's possible to load # things which respond to #call. HTTP status lines in responses --=20 2.26.2